unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [patch] variable datums with syncase transformer
Date: Wed, 05 Mar 2008 17:34:26 +0100	[thread overview]
Message-ID: <87y78xqgdp.fsf@gnu.org> (raw)
In-Reply-To: 1197619616.5218.34.camel@nocandy.dyndns.org


Stephen Compall <s11@member.fsf.org> writes:

> ludo@gnu.org (Ludovic Courtès) writes:
>> OTOH, you can (should?) use `use-modules':
>> <snip>
>> 
>> I don't even understand what the difference is between using
>> `use-modules' and `use-syntax' for `(ice-9 syncase)'.
>
> guile> (use-modules (ice-9 syncase))
> guile> (define-syntax x-of-y
>          (lambda (stx)
>            (syntax-case stx ()
>              (_ (syntax (hashq-ref y 'x))))))
> guile> x-of-y
> #<macro! sc-macro>
>
> ;;restart
> guile> ;;same as above, using use-syntax instead
> guile> x-of-y
>
> Backtrace:
> In unknown file:
>    ?: 0* [hashq-ref ...

Oh, forgive my ignorance, I didn't know `syntax-case' allowed non-list
patterns.  It makes me like syntax transformers a bit more.  ;-)

Getting back to your initial problem...

> guile> (use-syntax (ice-9 syncase))
> guile> (@ (guile) car)
> ERROR: invalid syntax #<variable b7c50a40 value: #<primitive-procedure car>>

Note that `@' and `@@' rely on an interesting property of the evaluator:
you type `(@ (guile) car)', `@' returns a *variable*, but what you get
is a *procedure*, because in the meantime, the evaluator automagically
performed a `variable-ref'.  This is not very elegant in my opinion.

With that in mind, I propose instead the following patch, which also
fixes your problem AFAICS:

--- /home/ludo/src/guile/1.8/guile-core/ice-9/boot-9.scm.~1.356.2.10.~	2007-09-01 19:11:00.000000000 +0200
+++ /home/ludo/src/guile/1.8/guile-core/ice-9/boot-9.scm	2008-03-05 17:25:15.000000000 +0100
@@ -2988,7 +2988,7 @@
   (let ((var (module-variable (resolve-interface mod-name) var-name)))
     (if (not var)
 	(error "no such public variable" (list '@ mod-name var-name)))
-    var))
+    (variable-ref var)))
 
 ;; The '@@' macro is like '@' but it can also access bindings that
 ;; have not been explicitely exported.
@@ -2997,7 +2997,7 @@
   (let ((var (module-variable (resolve-module mod-name) var-name)))
     (if (not var)
 	(error "no such variable" (list '@@ mod-name var-name)))
-    var))
+    (variable-ref var)))
 
Would it be OK for you?

Thanks,
Ludovic.





  parent reply	other threads:[~2008-03-05 16:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-14  8:06 [patch] variable datums with syncase transformer Stephen Compall
2008-03-05 14:59 ` Ludovic Courtès
2008-03-05 15:36   ` Stephen Compall
2008-03-05 16:34 ` Ludovic Courtès [this message]
2008-03-05 20:55   ` Neil Jerram
2008-03-05 22:16     ` Stephen Compall
2008-03-05 23:21     ` Ludovic Courtès
2008-03-06 23:28 ` Neil Jerram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y78xqgdp.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).