From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Universally-unique gensyms Date: Wed, 18 Jan 2012 23:23:24 +0100 Message-ID: <87y5t4ejkz.fsf@pobox.com> References: <87hazu1msh.fsf@netris.org> <87ehuyh1nf.fsf@pobox.com> <87ipk9zba2.fsf@netris.org> <87d3agu1rt.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1326925423 9577 80.91.229.12 (18 Jan 2012 22:23:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 18 Jan 2012 22:23:43 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=), "Mark H. Weaver" Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Jan 18 23:23:39 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rndup-0006RL-Vz for guile-devel@m.gmane.org; Wed, 18 Jan 2012 23:23:36 +0100 Original-Received: from localhost ([::1]:47170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rndup-0006iZ-E3 for guile-devel@m.gmane.org; Wed, 18 Jan 2012 17:23:35 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:42527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rndum-0006iU-LA for guile-devel@gnu.org; Wed, 18 Jan 2012 17:23:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rndul-0007Tb-2v for guile-devel@gnu.org; Wed, 18 Jan 2012 17:23:32 -0500 Original-Received: from a-pb-sasl-sd.pobox.com ([74.115.168.62]:58521 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rnduk-0007TW-TH; Wed, 18 Jan 2012 17:23:30 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 545A281F1; Wed, 18 Jan 2012 17:23:29 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=iBGfBbhhWdiy 14lkXULjdYVDxBg=; b=oUDSoD6mMHaXZGygWEs2o9VdeAqHLpf/4pwc8f197b+E Fwu5QRhf9hEGZv5LyKm0b+wCxUVxWPJqtsHuWqQakW7Zcjeuuv7fbXIoiZVh7eeR 8Q01rbFMEpiReVU5LxhvjTJEoTNJasf90BynCRcHmcwHgpkPOWoAMPwQLJZwmY4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=Z46KMI QXI+wHpVjby1FDUtL9LaZBizEDqjCu1rh2NrgdQrtKzWhdiMpXup28Rb63cMPFAA 5qY8698/YHyaa2xsIHRazFwP44uGNMZ92iNnNPtvIbjWomEgeXh/NWeQ+7RpGAi2 vgvidFu2c52eXkN4zOpotE7PT+TBLgEIWvCq0= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 4CA8281F0; Wed, 18 Jan 2012 17:23:29 -0500 (EST) Original-Received: from badger (unknown [90.164.198.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id A331E81EE; Wed, 18 Jan 2012 17:23:28 -0500 (EST) In-Reply-To: <87d3agu1rt.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 18 Jan 2012 22:41:26 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-Pobox-Relay-ID: 0BDD484A-4223-11E1-9FF5-65B1DE995924-02397024!a-pb-sasl-sd.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 74.115.168.62 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:13572 Archived-At: On Wed 18 Jan 2012 22:41, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Could you stick to GNU-style change logs, describing the change (for > example, =E2=80=9CNew function=E2=80=9D), and not the rationale, function= , etc.? > > (Andy might disagree with me, but don=E2=80=99t listen to him. ;-)) FWIW I have grown to agree with you over time, and your chiding, while not always well-received in the moment, has made for better commit logs :) >> + static const char base64[GENSYM_RADIX] =3D >> + "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789$@"; >> + static const char base4[4] =3D "_.-~"; > > Could we use Gnulib=E2=80=99s =E2=80=98base64=E2=80=99 module instead? FWIW (again) I thought the same initially, but Mark is incrementing a base64 buffer instead of continually reencoding a value. It seems OK in this instance. >> + /* Thread-local gensym counter. >> + */ >> + unsigned char *gensym_counter; > > Apparently this doesn=E2=80=99t break the ABI, right? Interesting. Sorry for asking a stupid question, but why is it that we want the gensym counter to be thread-local? Just to avoid the mutex? TBH I don't think it's that big of a point of contention. This risks devolution into bike-shed-landia tho... Regards Andy --=20 http://wingolog.org/