From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: Adding new information to scm_t_port (was Re: always O_BINARY?) Date: Fri, 01 Mar 2013 10:03:16 +0100 Message-ID: <87y5e78pbf.fsf@gnu.org> References: <87vc9ij5z0.fsf@pobox.com> <87fw0l2yyk.fsf@gnu.org> <877gltxgrg.fsf_-_@tines.lan> <87y5e8stst.fsf@pobox.com> <87k3psbsyc.fsf@gnu.org> <87ip5cr3f6.fsf@pobox.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1362128809 5174 80.91.229.3 (1 Mar 2013 09:06:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Mar 2013 09:06:49 +0000 (UTC) Cc: Mark H Weaver , guile-devel@gnu.org To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Mar 01 10:07:10 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UBLvn-0001RX-0l for guile-devel@m.gmane.org; Fri, 01 Mar 2013 10:07:07 +0100 Original-Received: from localhost ([::1]:33402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBLvR-0005GH-Rb for guile-devel@m.gmane.org; Fri, 01 Mar 2013 04:06:45 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBLsG-0008WR-NJ for guile-devel@gnu.org; Fri, 01 Mar 2013 04:03:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UBLsF-0003f8-GX for guile-devel@gnu.org; Fri, 01 Mar 2013 04:03:28 -0500 Original-Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=55823 helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBLsF-0003do-9r for guile-devel@gnu.org; Fri, 01 Mar 2013 04:03:27 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id 5BE6ACB9B; Fri, 1 Mar 2013 10:03:17 +0100 (CET) Original-Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fHIA6BdiUDTZ; Fri, 1 Mar 2013 10:03:17 +0100 (CET) Original-Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id BC21CC661; Fri, 1 Mar 2013 10:03:16 +0100 (CET) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 11 =?utf-8?Q?Vent=C3=B4se?= an 221 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <87ip5cr3f6.fsf@pobox.com> (Andy Wingo's message of "Thu, 28 Feb 2013 14:09:01 +0100") User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2a01:e0b:1:123:ca0a:a9ff:fe03:271e X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15850 Archived-At: Andy Wingo skribis: > On Thu 28 Feb 2013 12:04, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Andy Wingo skribis: >> >>> On Thu 28 Feb 2013 04:24, Mark H Weaver writes: >>> >>>> Instead of having 'input_cd' and 'output_cd' point directly to the >>>> platform's iconv_t structures, let's have them point to our own intern= al >>>> structure(s) that hold the needed transcoder state. This could include >>>> things like the state for internally-implement encoding(s) (e.g. UTF-8 >>>> BOM handling), EOL style, and iconv_t pointer(s) if appropriate. >>> >>> Great idea. >>> >>> I would call it a generic "port-private" data structure; it is not >>> limited to transcoder state. >>> >>> struct scm_t_port_private; >>> #define SCM_I_PORT_PRIVATE ((struct scm_t_port_private*)((ptob)->inpu= t_cd)) >> >> Sounds good to me, perhaps with =E2=80=98input_cd=E2=80=99 changed to = =E2=80=98internal=E2=80=99 or >> similar. > > That would be an API break; probably best to keep it with the same name, > no? Though I guess it doesn't matter in this particular case... I=E2=80=99d say it doesn=E2=80=99t matter in this case because I can hardly= imagine someone doing something useful with =E2=80=98input_cd=E2=80=99 outside of G= uile. Ludo=E2=80=99.