From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] allow specifying a required version in GUILE_PROGS Date: Fri, 18 Oct 2013 23:50:34 +0200 Message-ID: <87y55qfdud.fsf@gnu.org> References: <87vc0zh8az.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1382133050 3329 80.91.229.3 (18 Oct 2013 21:50:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Oct 2013 21:50:50 +0000 (UTC) Cc: guile-devel To: Aleix Conchillo =?utf-8?Q?Flaqu=C3=A9?= Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Oct 18 23:50:54 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VXHwb-0000kZ-AM for guile-devel@m.gmane.org; Fri, 18 Oct 2013 23:50:53 +0200 Original-Received: from localhost ([::1]:59481 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXHwa-00029v-N9 for guile-devel@m.gmane.org; Fri, 18 Oct 2013 17:50:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXHwQ-00029i-Nm for guile-devel@gnu.org; Fri, 18 Oct 2013 17:50:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VXHwK-0002fa-Of for guile-devel@gnu.org; Fri, 18 Oct 2013 17:50:42 -0400 Original-Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:36626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXHwK-0002cY-4z for guile-devel@gnu.org; Fri, 18 Oct 2013 17:50:36 -0400 X-IronPort-AV: E=Sophos;i="4.93,525,1378850400"; d="scan'208";a="30930756" Original-Received: from reverse-83.fdn.fr (HELO pluto) ([80.67.176.83]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA; 18 Oct 2013 23:50:34 +0200 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 =?utf-8?Q?Vend=C3=A9miaire?= an 222 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: ("Aleix Conchillo \=\?utf-8\?Q\?Flaqu\=C3\=A9\=22's\?\= message of "Mon, 14 Oct 2013 14:35:43 -0700") User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.134.164.104 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16682 Archived-At: Aleix Conchillo Flaqu=C3=A9 skribis: > Hi! > > On Mon, Oct 14, 2013 at 2:05 PM, Ludovic Court=C3=A8s wrot= e: >> Hi Aleix, >> >> (Second try.) >> >> The patch looks good to me. >> >> Perhaps error messages should show >> $_guile_major_version.$_guile_minor_version.$_guile_micro_version since >> that could differ from $_guile_prog_version (for instance in Debian >> $_guile_prog_version is something like 2.0.9-deb42.) >> > > Yes, I saw that and thought it was OK as the check was successfully > anyway. But probably it looks better as you suggested. In the attached > patch I don't get the version from (version) and I build > _guile_prog_version with macro.minor.micro. The new version looks good to me. I forgot, but while waiting for the assignment to be on file ;-), could you update the manual entry for =E2=80=98GUILE_PROGS=E2=80=99? Thanks, Ludo=E2=80=99.