From: Andy Wingo <wingo@pobox.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: MinGW-related patches that were reported in 2014 but not applied
Date: Sat, 23 Jul 2016 14:15:06 +0200 [thread overview]
Message-ID: <87y44ssg8l.fsf@pobox.com> (raw)
In-Reply-To: <83h9bp6d1i.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Jul 2016 14:24:41 +0300")
On Sat 16 Jul 2016 13:24, Eli Zaretskii <eliz@gnu.org> writes:
> From f55f1e8de40b38cc745a930bf5a374c73d3c67ce Mon Sep 17 00:00:00 2001
> From: Eli Zaretskii <eliz@gnu.org>
> Date: Sat, 16 Jul 2016 14:22:06 +0300
> Subject: [PATCH] Fix 'strftime' for MS-Windows
>
> * libguile/stime.c (scm_strftime) [__MINGW32__]: Don't use the
> trick of appending "0" to the time-zone string, Windows runtime
> doesn't support that.
> +#ifndef __MINGW32__
> + /* Don't do this for MinGW: it only supports fixed-format
> + TTTnnnDDD TZ specifications, and gets confused if a zero is
> + appended. */
This patch disables the setzone() call entirely; seems to be the wrong
thing, given that MinGW doesn't appear to have struct tm->tm_zone. What
if we just disable appending the 0 to the time zone?
Andy
next prev parent reply other threads:[~2016-07-23 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 19:04 MinGW-related patches that were reported in 2014 but not applied Eli Zaretskii
2016-07-16 8:33 ` Andy Wingo
2016-07-16 11:24 ` Eli Zaretskii
2016-07-16 13:39 ` Andy Wingo
2016-07-16 15:37 ` Eli Zaretskii
2016-07-23 9:58 ` Andy Wingo
2016-07-23 12:15 ` Andy Wingo [this message]
2016-07-23 13:07 ` Eli Zaretskii
2016-07-23 20:36 ` Andy Wingo
2016-07-24 15:10 ` Eli Zaretskii
2016-07-17 6:04 ` Andy Wingo
-- strict thread matches above, loose matches on Subject: below --
2016-07-22 10:21 Eli Zaretskii
2016-07-23 11:51 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y44ssg8l.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=eliz@gnu.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).