From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file Date: Tue, 14 Mar 2017 16:56:27 +0100 Message-ID: <87y3w76edw.fsf@pobox.com> References: <878to9s5s9.fsf@pobox.com> <87h92v7vw3.fsf@pobox.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489507013 16910 195.159.176.226 (14 Mar 2017 15:56:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 14 Mar 2017 15:56:53 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: guile-devel@gnu.org To: Freja Nordsiek Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Mar 14 16:56:48 2017 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnooV-0003UF-4E for guile-devel@m.gmane.org; Tue, 14 Mar 2017 16:56:43 +0100 Original-Received: from localhost ([::1]:60292 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnoob-0004yF-6B for guile-devel@m.gmane.org; Tue, 14 Mar 2017 11:56:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnooS-0004y7-90 for guile-devel@gnu.org; Tue, 14 Mar 2017 11:56:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnooO-0003CQ-BY for guile-devel@gnu.org; Tue, 14 Mar 2017 11:56:40 -0400 Original-Received: from pb-sasl2.pobox.com ([64.147.108.67]:50098 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cnooO-0003Bm-6v for guile-devel@gnu.org; Tue, 14 Mar 2017 11:56:36 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 62F9E69AA9; Tue, 14 Mar 2017 11:56:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=p+oMU1Q0GwdtuU6n1LCyBe+QiXk=; b=Uj7KS/ yq8JVm/PeC6nySokULCMXZyKaeOdHJvJrqRSyfY8H5U5r2SFra73VtvUKl2iVlGS CcdMuwZwYYAMQscK3bbVqEz28vgEgtE7DKHHjP4T/B/DrwN2sJpV6vFY/I/oJ0VY 0DOaBleQXLww9YKwJjjCrp9nSeuG0hRXnUE7w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=xJeAksbzkYIB2AHR3bB7k8/qSkhVXtm+ wySJuwDKuwcOkfjuGkBruSWYP5x7haxmJVfycIyR/33NoVah5icTaqaiyRIVRQn6 L633nvVfDa9Q/R+r+vUYTfyzOEhaJ8CPpul2omuU58tE6kyYCalRqPdEIKWUHM3E 1RA3hOh2H34= Original-Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 5D90469AA8; Tue, 14 Mar 2017 11:56:35 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 573B469AA7; Tue, 14 Mar 2017 11:56:34 -0400 (EDT) In-Reply-To: (Freja Nordsiek's message of "Tue, 14 Mar 2017 16:31:17 +0100") X-Pobox-Relay-ID: CC914B96-08CE-11E7-9740-85AB91A0D1B0-02397024!pb-sasl2.pobox.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.108.67 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:19050 Archived-At: Heya :) On Tue 14 Mar 2017 16:31, Freja Nordsiek writes: > From 41498549ac22ea50e497887b3a1e002985bb6f8f Mon Sep 17 00:00:00 2001 > From: Freja Nordsiek > Date: Tue, 14 Mar 2017 16:28:45 +0100 > Subject: [PATCH] GUILE_SITE_DIR: Find site directories for compiled files. > Here in the commit log you need entries for the files you change and the functions you change in them. See 036cc149e6e52722f16ef25f4203e82abae9bc79 for an example. I know it's a bit of a drag but it's how it is. (In Magit, if you use that, you can press C in a diff to make a template in the log.) > -# GUILE_SITE_DIR -- find path to Guile "site" directory > +# GUILE_SITE_DIR -- find path to Guile site directories > # > # Usage: GUILE_SITE_DIR > # > -# This looks for Guile's "site" directory, usually something like > -# PREFIX/share/guile/site, and sets var @var{GUILE_SITE} to the path. > -# Note that the var name is different from the macro name. > +# This looks for Guile's "site" directories. The variable @var{GUILE_SITE} will > +# be set to Guile's "site" directory for Scheme source files (usually something like > +# PREFIX/share/guile/site). @var{GUILE_SITE_CCACHE} will be set to the directory > +# for compiled Scheme files also known as @code{.go} files > +# (usually something like PREFIX/lib/guile/@var{GUILE_EFFECTIVE_VERSION}/site-ccache). > +# @var{GUILE_EXTENSION} will be set to the directory for compiled C extensions > +# (usually something like # PREFIX/lib/guile/@var{GUILE_EFFECTIVE_VERSION}/extensions). > +# The latter two are set to blank if the particular version of Guile does not support > +# them. Note that this macro will run the macros @code{GUILE_PKG} and @code{GUILE_PROGS} > +# if they have not already been run. Please limit lines to < 80 characters. If you use emacs, you can fix with M-q, provided your fill-column is set appropriately. > AC_SUBST(GUILE_SITE) > + AC_MSG_CHECKING([for Guile site-ccache directory using pkgconfig]) > + GUILE_SITE_CCACHE=`$PKG_CONFIG --print-errors --variable=siteccachedir guile-$GUILE_EFFECTIVE_VERSION` Is --print-errors the right thing here? I guess this causes some text to spew on the console for 2.0. Probably not the right thing if we're going to fall back. Otherwise good. Apologies for the nit-picking; I'm doing it now just so that things are fluid in the future :) Andy