Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file

[Andy Wingo <wingo@pobox.com>]

Heya :)

On Tue 14 Mar 2017 16:31, Freja Nordsiek <fnordsie@gmail.com> writes:

> From 41498549ac22ea50e497887b3a1e002985bb6f8f Mon Sep 17 00:00:00 2001
> From: Freja Nordsiek <fnordsie@gmail.com>
> Date: Tue, 14 Mar 2017 16:28:45 +0100
> Subject: [PATCH] GUILE_SITE_DIR: Find site directories for compiled files.
>

Here in the commit log you need entries for the files you change and the
functions you change in them.  See
036cc149e6e52722f16ef25f4203e82abae9bc79 for an example.  I know it's a
bit of a drag but it's how it is.  (In Magit, if you use that, you can
press C in a diff to make a template in the log.)

> -# GUILE_SITE_DIR -- find path to Guile "site" directory
> +# GUILE_SITE_DIR -- find path to Guile site directories
>  #
>  # Usage: GUILE_SITE_DIR
>  #
> -# This looks for Guile's "site" directory, usually something like
> -# PREFIX/share/guile/site, and sets var @var{GUILE_SITE} to the path.
> -# Note that the var name is different from the macro name.
> +# This looks for Guile's "site" directories.  The variable @var{GUILE_SITE} will
> +# be set to Guile's "site" directory for Scheme source files (usually something like
> +# PREFIX/share/guile/site).  @var{GUILE_SITE_CCACHE} will be set to the directory
> +# for compiled Scheme files also known as @code{.go} files
> +# (usually something like PREFIX/lib/guile/@var{GUILE_EFFECTIVE_VERSION}/site-ccache).
> +# @var{GUILE_EXTENSION} will be set to the directory for compiled C extensions
> +# (usually something like # PREFIX/lib/guile/@var{GUILE_EFFECTIVE_VERSION}/extensions).
> +# The latter two are set to blank if the particular version of Guile does not support
> +# them.  Note that this macro will run the macros @code{GUILE_PKG} and @code{GUILE_PROGS}
> +# if they have not already been run.

Please limit lines to < 80 characters.  If you use emacs, you can fix
with M-q, provided your fill-column is set appropriately.

>    AC_SUBST(GUILE_SITE)
> +  AC_MSG_CHECKING([for Guile site-ccache directory using pkgconfig])
> +  GUILE_SITE_CCACHE=`$PKG_CONFIG --print-errors --variable=siteccachedir guile-$GUILE_EFFECTIVE_VERSION`

Is --print-errors the right thing here?  I guess this causes some text
to spew on the console for 2.0.  Probably not the right thing if we're
going to fall back.

Otherwise good.  Apologies for the nit-picking; I'm doing it now just so
that things are fluid in the future :)

Andy