From: Andy Wingo <wingo@igalia.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guile Devel <guile-devel@gnu.org>
Subject: Re: CPU and GC cost of bignums
Date: Thu, 06 Feb 2020 10:37:54 +0100 [thread overview]
Message-ID: <87y2tgawel.fsf@igalia.com> (raw)
In-Reply-To: <87zhdxknf9.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 05 Feb 2020 17:29:30 +0100")
Hi :)
Nice investigation! Perhaps slot-allocation should track live variables
using something that's not bigints, but who knows.
On Wed 05 Feb 2020 17:29, Ludovic Courtès <ludo@gnu.org> writes:
> /* The next three functions (custom_libgmp_*) are passed to
> mp_set_memory_functions (in GMP) so that memory used by the digits
> themselves is known to the garbage collector. This is needed so
> @@ -237,19 +227,20 @@ finalize_bignum (void *ptr, void *data)
> static void *
> custom_gmp_malloc (size_t alloc_size)
> {
> - return scm_malloc (alloc_size);
> + return scm_gc_malloc (alloc_size, "GMP");
> }
>
> static void *
> custom_gmp_realloc (void *old_ptr, size_t old_size, size_t new_size)
> {
> - return scm_realloc (old_ptr, new_size);
> + return scm_gc_realloc (old_ptr, old_size, new_size, "GMP");
> }
>
> static void
> custom_gmp_free (void *ptr, size_t size)
> {
> - free (ptr);
> + /* Do nothing: all memory allocated by GMP is under GC control and
> + will be freed when needed. */
> }
I think this makes sense to me as a short-term fix. The down-side is
that limbs can alias Scheme objects.
In the long-term I think we should be representing bignums as
pointerless objects whose first word is the tag and a word count,
followed by inline "limbs" (in the sense of
https://gmplib.org/manual/Nomenclature-and-Types.html#Nomenclature-and-Types).
Generally we can use the low-level API to work on these
(https://gmplib.org/manual/Low_002dlevel-Functions.html#Low_002dlevel-Functions),
and if we need to use mpz_t, we can easily create an mpz_t that points
to these values.
Cheers,
Andy
next prev parent reply other threads:[~2020-02-06 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 16:56 CPU and GC cost of bignums Ludovic Courtès
2020-02-05 16:29 ` Ludovic Courtès
2020-02-05 21:28 ` Hans Åberg
2020-02-06 9:37 ` Andy Wingo [this message]
2020-02-06 13:37 ` Ludovic Courtès
2020-02-08 14:05 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2tgawel.fsf@igalia.com \
--to=wingo@igalia.com \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).