From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robin Templeton Newsgroups: gmane.lisp.guile.devel Subject: Re: Guile 3 and wip-elisp/Emacs Date: Thu, 21 Oct 2021 15:34:03 -0400 Message-ID: <87y26mkw9g.fsf@terpri.org> References: <87mtogpwvi.fsf@elephly.net> <47-61683200-11-6332ae00@255428996> <875ytx5wvg.fsf@dustycloud.org> <875yts7jcp.fsf@dustycloud.org> <87tuhc642o.fsf@gnu.org> <874k9c5ulu.fsf@dustycloud.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20847"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) To: guile-devel@gnu.org Cancel-Lock: sha1:doRF6eicd7TXEJbSiqbQC8XzVXE= Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Thu Oct 21 21:34:55 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mddq2-00057d-RZ for guile-devel@m.gmane-mx.org; Thu, 21 Oct 2021 21:34:54 +0200 Original-Received: from localhost ([::1]:47562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mddq0-0001Ve-To for guile-devel@m.gmane-mx.org; Thu, 21 Oct 2021 15:34:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mddpT-0001Tv-9b for guile-devel@gnu.org; Thu, 21 Oct 2021 15:34:19 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:49796) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mddpQ-0004mZ-Rl for guile-devel@gnu.org; Thu, 21 Oct 2021 15:34:18 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mddpO-0004E3-S1 for guile-devel@gnu.org; Thu, 21 Oct 2021 21:34:14 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=guile-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20928 Archived-At: Christine Lemmer-Webber writes: > Ludovic Courtès writes: > >> Hello! >> >> Christine Lemmer-Webber skribis: >> >>> I've pushed this as origin/wip-elisp-rebased. I actually rebased it >>> again, making some naming adjustments for myself and a couple of >>> adjustments having talked to Robin. >>> >>> If nobody objects, I'd like to merge this into main. Maintainers, if >>> you have any objections, speak now or forever hold these commits! >> >> I haven’t looked at the branch, but I think it’s great to see it live >> and it’s great if it can be merged! > > I just compiled the rebased version and will be playing with it little > bits over the next few days to make sure it's reasonably good. > >> Some things to pay attention to before merging to ‘main’, since it >> corresponds to the current 3.0 stable branch: >> >> • Make sure no backward incompatibilities are introduced in >> preexisting modules; >> >> • Make sure the ABI of libguile-3.0.so and that of public modules >> is unchanged, or is changed compatibly; > > There are, I think, two commits that could use review, but I am NOT the > right person to do this. > > 4e96211eb666751b8666beb918bf3108aa1c725b intern arbitrary constants > 433fc448ddb018767906f8808203c9668c68cd83 multiple obarrays I'll take a look at these... > [...] (and maybe the "guile-private-ref" and "allow > arbitrary constants in cps" commits look relevant too). and these, but concur that Andy is the best person to review them, and I agree that Andy should approve the merge overall in any case. Still reviewing the wip-elisp-rebased branch in my spare time; so far I haven't found any noteworthy problems, not that I was expecting to :) A minor point: IMHO the "(Best-ability ChangeLog annotation ...)" lines aren't the ideal way to credit you, in terms of commit message formatting. I'd prefer using git 'trailers' for in-commit credit, so that it's obvious to both humans and git that it's commit metadata. I'm not sure there's a conventional git trailer for this...something like 'ChangeLog-by:' would be probably be clear enough. But if you prefer the current formatting and it works with Guile's ChangeLog generator, I don't mind leaving it as-is (except perhaps "s/Best-ability //" after I've reviewed everything :)) WDYT? Thanks, Robin -- "You have to act as if it were possible to radically transform the world. And you have to do it all the time." -- Angela Davis