From: Robin Templeton <robin@terpri.org>
To: guile-devel@gnu.org
Subject: Re: Guile 3 and wip-elisp/Emacs
Date: Thu, 21 Oct 2021 15:34:03 -0400 [thread overview]
Message-ID: <87y26mkw9g.fsf@terpri.org> (raw)
In-Reply-To: 874k9c5ulu.fsf@dustycloud.org
Christine Lemmer-Webber <cwebber@dustycloud.org> writes:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello!
>>
>> Christine Lemmer-Webber <cwebber@dustycloud.org> skribis:
>>
>>> I've pushed this as origin/wip-elisp-rebased. I actually rebased it
>>> again, making some naming adjustments for myself and a couple of
>>> adjustments having talked to Robin.
>>>
>>> If nobody objects, I'd like to merge this into main. Maintainers, if
>>> you have any objections, speak now or forever hold these commits!
>>
>> I haven’t looked at the branch, but I think it’s great to see it live
>> and it’s great if it can be merged!
>
> I just compiled the rebased version and will be playing with it little
> bits over the next few days to make sure it's reasonably good.
>
>> Some things to pay attention to before merging to ‘main’, since it
>> corresponds to the current 3.0 stable branch:
>>
>> • Make sure no backward incompatibilities are introduced in
>> preexisting modules;
>>
>> • Make sure the ABI of libguile-3.0.so and that of public modules
>> is unchanged, or is changed compatibly;
>
> There are, I think, two commits that could use review, but I am NOT the
> right person to do this.
>
> 4e96211eb666751b8666beb918bf3108aa1c725b intern arbitrary constants
> 433fc448ddb018767906f8808203c9668c68cd83 multiple obarrays
I'll take a look at these...
> [...] (and maybe the "guile-private-ref" and "allow
> arbitrary constants in cps" commits look relevant too).
and these, but concur that Andy is the best person to review them, and I
agree that Andy should approve the merge overall in any case.
Still reviewing the wip-elisp-rebased branch in my spare time; so far I
haven't found any noteworthy problems, not that I was expecting to :)
A minor point: IMHO the "(Best-ability ChangeLog annotation ...)" lines
aren't the ideal way to credit you, in terms of commit message
formatting. I'd prefer using git 'trailers' for in-commit credit, so
that it's obvious to both humans and git that it's commit metadata. I'm
not sure there's a conventional git trailer for this...something like
'ChangeLog-by:' would be probably be clear enough. But if you prefer the
current formatting and it works with Guile's ChangeLog generator, I
don't mind leaving it as-is (except perhaps "s/Best-ability //" after
I've reviewed everything :)) WDYT?
Thanks,
Robin
--
"You have to act as if it were possible to radically transform the
world. And you have to do it all the time." -- Angela Davis
next prev parent reply other threads:[~2021-10-21 19:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 15:12 Guile 3 and wip-elisp/Emacs Gregg Sangster
2021-09-10 19:59 ` Dr. Arne Babenhauserheide
2021-09-13 2:13 ` Christine Lemmer-Webber
2021-10-14 14:01 ` Gregg Sangster
2021-10-14 17:34 ` Ricardo Wurmus
2021-10-20 10:56 ` Gregg Sangster
2021-10-21 14:05 ` Ricardo Wurmus
2021-10-21 17:49 ` Robin Templeton
2021-10-20 11:59 ` Robin Templeton
2021-09-13 10:56 ` Ricardo Wurmus
2021-09-20 10:39 ` Gerry Agbobada
2021-10-14 13:35 ` Gregg Sangster
2021-10-16 5:25 ` Christine Lemmer-Webber
2021-10-19 21:59 ` Christine Lemmer-Webber
2021-10-19 22:29 ` Ludovic Courtès
2021-10-20 1:46 ` Christine Lemmer-Webber
2021-10-20 2:51 ` Christine Lemmer-Webber
2021-10-20 16:27 ` Christopher Allan Webber
2021-10-22 16:11 ` Christine Lemmer-Webber
2021-10-22 16:17 ` Christine Lemmer-Webber
2021-10-22 18:38 ` Gregg Sangster
2021-10-21 19:34 ` Robin Templeton [this message]
2021-10-22 2:59 ` Christine Lemmer-Webber
2021-10-20 10:43 ` Gregg Sangster
2021-10-20 11:43 ` Robin Templeton
-- strict thread matches above, loose matches on Subject: below --
2021-09-10 15:09 Gregg Sangster
2021-09-10 15:09 Gregg Sangster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y26mkw9g.fsf@terpri.org \
--to=robin@terpri.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).