From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.lisp.guile.devel Subject: Re: Introduction of fractions exposes uniform vector prototype bug Date: Tue, 10 Feb 2004 10:05:37 +1000 Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Message-ID: <87wu6vpzn2.fsf@zip.com.au> References: <87zndowks7.fsf@zip.com.au> <87u1331m72.fsf@zagadka.ping.de> <87oetbe7an.fsf@zip.com.au> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1076371753 29673 80.91.224.253 (10 Feb 2004 00:09:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 10 Feb 2004 00:09:13 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Feb 10 01:09:05 2004 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AqLSa-0002ib-00 for ; Tue, 10 Feb 2004 01:09:04 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AqLQU-0005pb-CU for guile-devel@m.gmane.org; Mon, 09 Feb 2004 19:06:54 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AqLPy-0005m9-AC for guile-devel@gnu.org; Mon, 09 Feb 2004 19:06:22 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AqLPR-0005SG-A5 for guile-devel@gnu.org; Mon, 09 Feb 2004 19:06:21 -0500 Original-Received: from [61.8.0.85] (helo=mailout2.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AqLPN-0005S2-Dv for guile-devel@gnu.org; Mon, 09 Feb 2004 19:05:45 -0500 Original-Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout2.pacific.net.au (8.12.3/8.12.3/Debian-6.6) with ESMTP id i1A05h5O003311 for ; Tue, 10 Feb 2004 11:05:43 +1100 Original-Received: from localhost (ppp57.dyn251.pacific.net.au [203.143.251.57]) by mailproxy1.pacific.net.au (8.12.3/8.12.3/Debian-6.6) with ESMTP id i1A05ft3025479 for ; Tue, 10 Feb 2004 11:05:42 +1100 Original-Received: from gg by localhost with local (Exim 3.36 #1 (Debian)) id 1AqLPF-0001OA-00; Tue, 10 Feb 2004 10:05:37 +1000 Original-To: guile-devel@gnu.org Mail-Copies-To: never User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Developers list for Guile, the GNU extensibility library List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.devel:3355 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:3355 The changes will be, * unif.c (scm_make_uve, scm_array_p): Allow fraction 1/3 as prototype for dvect. (scm_array_p): Add missing "break"s in switch, fix llvect test look for "l" not "s", fix dvect to reject singp(prot) which is for fvect. (scm_array_prototype): Return 1/3 for dvect, rather than 0.33..33. * ramap.c (scm_array_fill_x): For fvect and dvect, use scm_num2dbl to convert args the same way that array-set! does. Looks like nobody ever ran array? with the prototype argument, the missing "break"s made it completely broken. That fix will be for the 1.6 branch too I think. (And in 1.6 there needs to be a NIMP before singp in the fvect case.) _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://mail.gnu.org/mailman/listinfo/guile-devel