unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Kevin Ryde <user42@zip.com.au>
Subject: Re: Introduction of fractions exposes uniform vector prototype bug
Date: Tue, 10 Feb 2004 10:05:37 +1000	[thread overview]
Message-ID: <87wu6vpzn2.fsf@zip.com.au> (raw)
In-Reply-To: 87oetbe7an.fsf@zip.com.au

The changes will be,

        * unif.c (scm_make_uve, scm_array_p): Allow fraction 1/3 as prototype
        for dvect.
        (scm_array_p): Add missing "break"s in switch, fix llvect test look
        for "l" not "s", fix dvect to reject singp(prot) which is for fvect.
        (scm_array_prototype): Return 1/3 for dvect, rather than 0.33..33.

        * ramap.c (scm_array_fill_x): For fvect and dvect, use scm_num2dbl to
        convert args the same way that array-set! does.

Looks like nobody ever ran array? with the prototype argument, the
missing "break"s made it completely broken.  That fix will be for the
1.6 branch too I think.

(And in 1.6 there needs to be a NIMP before singp in the fvect case.)


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel


  reply	other threads:[~2004-02-10  0:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-25 23:02 Introduction of fractions exposes uniform vector prototype bug Mikael Djurfeldt
2003-12-19 21:38 ` Kevin Ryde
2003-12-20 16:12   ` tomas
2003-12-20 17:52     ` Stephen Compall
2003-12-21  0:42     ` Kevin Ryde
2004-01-10 22:19   ` Marius Vollmer
2004-01-10 23:02     ` Kevin Ryde
2004-02-10  0:05       ` Kevin Ryde [this message]
2004-02-10 23:30         ` Rob Browning
2004-02-12  0:26           ` Kevin Ryde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wu6vpzn2.fsf@zip.com.au \
    --to=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).