David Fang writes: > Hi all, > > Minor nit about the "libguile/inline.h" header: > > I typically compile with g++ ... -Wundef -Werror, which catches uses > of undefined preprocessor tokens: > > /usr/local/include/libguile/inline.h:57:31: "__APPLE_CC__" is not defined > In file included from /usr/local/include/libguile.h:114, > /usr/local/include/libguile/inline.h:57:31: "__APPLE_CC__" is not defined > > __APPLE_CC__ is only defined for Apple, which is causing my compiles > to fail (didn't used to fail with older guile.) > > > Can we change line 57 from: > > # if (defined __GNUC__) && (!(__APPLE_CC__ > 5400 && __STDC_VERSION__ >>= 199901L > > to something like: > > # if (defined __GNUC__) && (!((defined __APPLE_CC__) && __APPLE_CC__ > > 5400 && __STDC_VERSION__ >= 199901L > > which checks for __APPLE_CC__ defined before using it? Sure. Proposed patch for this is attached, please let me know if any comments. Regards, Neil