Re: Locks and threads

[ludo@gnu.org (Ludovic Courtès)]

Hi Neil,

Neil Jerram <neil@ossau.uklinux.net> writes:

> Neil Jerram <neil@ossau.uklinux.net> writes:

>> Subject: [PATCH] Avoid throw from critical section, given invalid sigaction call
>>
>> * libguile/scmsigs.c (scm_sigaction_for_thread): Exit critical section
>>   before raising out-of-range error.
>>
>> * test-suite/Makefile.am (SCM_TESTS): Add signals.test.
>>
>> * test-suite/tests/signals.test: New file.
>
> I've committed this now too.  (Also to 1.8.x.  I'll come back later to
> look at which of all these lock fixes are needed in master.)

Perfect!

This one can go in `master' too, I think.

Neil Jerram <neil@ossau.uklinux.net> writes:

> Neil Jerram <neil@ossau.uklinux.net> writes:
>
>> I've been running Linas's define-race test program, and hitting the
>> `throw from within critical section' quite a lot.
>>
>> We've already discussed this a couple of times:
>> http://www.mail-archive.com/bug-guile@gnu.org/msg04613.html
>> http://www.mail-archive.com/guile-devel@gnu.org/msg03016.html
>>
>> Andy proposed just removing the check for 1.8.x, but I would prefer to
>> keep it if possible, as I think there probably still are genuine
>> problems where the check could help.  What about the patch below?
>
> I don't believe anyone commented on this, but I've committed it now to
> 1.8.x.  In case of any concerns, please let me know.

Sorry for not commenting earlier.  This looks good to me.  I suppose it
can't hurt in `master'; the future of critical sections is uncertain,
though.

Thanks!

Ludo'.