From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.lisp.guile.devel Subject: Re: 1.8 =?utf-8?B?4oCYc2VuZOKAmQ==?= bug + re-engagement Date: Thu, 20 Sep 2012 10:06:51 +0200 Message-ID: <87wqzp15k4.fsf@zigzag.favinet> References: <87txvs2wx7.fsf@zigzag.favinet> <87mx1jqcbp.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1348128425 26389 80.91.229.3 (20 Sep 2012 08:07:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Sep 2012 08:07:05 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Sep 20 10:07:10 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TEbmv-0000y0-K9 for guile-devel@m.gmane.org; Thu, 20 Sep 2012 10:07:09 +0200 Original-Received: from localhost ([::1]:43656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEbmr-0003UJ-1u for guile-devel@m.gmane.org; Thu, 20 Sep 2012 04:07:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEbmm-0003TF-Sb for guile-devel@gnu.org; Thu, 20 Sep 2012 04:07:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEbmf-0007rI-Tg for guile-devel@gnu.org; Thu, 20 Sep 2012 04:07:00 -0400 Original-Received: from smtp209.alice.it ([82.57.200.105]:45692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEbmZ-0007pc-1h; Thu, 20 Sep 2012 04:06:47 -0400 Original-Received: from zigzag.favinet (79.41.65.250) by smtp209.alice.it (8.6.023.02) id 504696FF02AEF94E; Thu, 20 Sep 2012 10:06:45 +0200 Original-Received: from ttn by zigzag.favinet with local (Exim 4.72) (envelope-from ) id 1TEbmq-0002SO-RL; Thu, 20 Sep 2012 10:07:04 +0200 In-Reply-To: <87mx1jqcbp.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 25 Aug 2012 16:24:26 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 82.57.200.105 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:14905 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable () ludo@gnu.org (Ludovic Court=C3=A8s) () Sat, 25 Aug 2012 16:24:26 +0200 > Looking to move WIKID[0] out of the Guile 1.4.x ghetto (which is > pretty cozy, i must say), (Speaking of which, do let me know when rpx has left the ghetto, too. :-)) OK, will do. If the world doesn't end, a couple more years, maybe... > =E2=80=98send=E2=80=99 gratuitously demands its MESSAGE arg (a string)= be writable. > [...] Here is the fix: Sounds great. There are =E2=80=98sendto=E2=80=99 unit tests, but no =E2= =80=98send=E2=80=99 tests. As a bonus, if you feel like adding a couple of these, you=E2=80=99re welcome. :-) I plan to add some tests, yes. > i'd like to apply the fix myself (in the savannah repo), onto > =E2=80=98branch_release-1-8=E2=80=99. Yes, please do! Can you apply it to stable-2.0 as well? Sorry, no; i lack sufficient bandwidth. > $ glog branch_release-1-8.. --reverse =E2=80=9Cglog=E2=80=9D? :-) A small script, here in its entirety: #!/bin/sh exec git log --date=3Dshort --format=3D'%h %ad %s' "$@" > [...] > 60a29ff [...] libguile: Fix bug: Don't expect 'send' [...] > d70f9c8 [...] > > Note that the fix is the penultimate change (60a29ff). How about i > push this to =E2=80=98ttn-back-in-the-saddle=E2=80=99 for review? Makes sense, yes. OK, just pushed. I await your review. I think I once said we SHOULD release 1.8.9 RSN. Would you like to take care of that? Yes. For 1.8.9, i plan to: =2D audit libguile for this (writable/read-only string) class of bug =2D add tests =2D back/forward-port tests =2D back/forward-port docs Further 1.8 releases will be similar, the goal being to transition from point-fixes to systemic improvements. On the side, i plan to improve the build environment (makefiles / configure.ac / doc-mangling). > The changes are done in a hybrid ttn-gnu maintainance style. I=E2=80=99m not sure what you mean here. :-) For example, the TITLE in a ChangeLog entry (in git jargon, the commit's "subject line") has no prescribed format. Guile HACKING refers to this only as "1-line description of change" (pretty loose), whereas ttn-style is to use a certain format, the germane part of which is the trailing "; nfc" to indicate that the change does not warrant a ChangeLog entry. (NFC stands for non-functionality -- i.e., cosmetic -- change.) Anyway, i see 1.8.8 tarball does not even include a proper ChangeLog, so that's an opportunity to backport the =E2=80=98gen-ChangeLog=E2=80=99 stuff= ... Other ttn-style stuff: no EOL whitespace, use SPC for indentation, strict EOF "ends here" comment maintenance. Where a file is not stylish enough :-D, the MO is to do these changes opportunistically (preceding the actual required change) in their own "nfc" commits. This MO is evidenced in the pushed branch. > I imagine if this particular fix goes smoothly, i will be motivated > to continue w/ this kind of maintenance work, where the focus is on > continuity and stability (perhaps likewise showing 1.6 and 1.4 some > love, as well). Hmm, I=E2=80=99d find it more important to help fix any issues that prev= ent current 1.8 users from switching to 2.0, FWIW. Well, that's why i'm here -- to do the non-important-for-ludo stuff (that happens to be important for others). I think the more you move your mind away from "switching" (XOR) and towards "stepping" (XOR, brief (or not) IOR, XOR), the more you will see value in what i do. =2D-=20 Thien-Thi Nguyen ..................................... GPG key: 4C807502 . NB: ttn at glug dot org is not me . . (and has not been since 2007 or so) . . ACCEPT NO SUBSTITUTES . ........... please send technical questions to mailing lists ........... --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAlBazp8ACgkQZwMiJEyAdQJppACdHD1KskScdYEbggK8wYgEJxKN GTwAoI11aB/f6Qd6b4hdu2dfABQoZ4Wn =ugsW -----END PGP SIGNATURE----- --=-=-=--