unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Andy Wingo <wingo@igalia.com>
Cc: guix-devel@gnu.org, 19439@debbugs.gnu.org,
	Steve Sprang <steve.sprang@gmail.com>,
	guile-devel@gnu.org
Subject: Re: [PATCH] gnu: Add erlang.
Date: Wed, 06 Jan 2016 17:07:51 +0100	[thread overview]
Message-ID: <87wprmg088.fsf@gnu.org> (raw)
In-Reply-To: <877fjpzi07.fsf@igalia.com> (Andy Wingo's message of "Mon, 04 Jan 2016 12:44:24 +0100")

On Mon 04 Jan 2016 06:20, Steve Sprang <steve.sprang@gmail.com> writes:

> From http://www.erlang.org/download/otp_src_18.2.1.tar.gz...
> ERROR: Bad qstring header component: kMSMAn68110840

Andy Wingo <wingo@igalia.com> skribis:

> The Etag value is invalid:
>
>   https://tools.ietf.org/html/rfc7232#section-2.3
>
> We could relax Guile's etag parser to assume that an etag not starting
> with either W/ or " is a strong etag without quotes.  To do that you
> would patch guile's http.scm to say:
>
> (define (parse-entity-tag val)
>   (cond
>    ((string-prefix? "W/" val) (cons (parse-qstring val 2) #f))
>    ((string-prefix? "\"" val) (cons (parse-qstring val) #t))
>    (else (cons val #t))))
>
> Considering that this error has come up a few times and that the less
> strict parser doesn't change the Guile programming interface or endanger
> the web in any significant way, I think changing Guile's HTTP parser
> would be OK.
>
> Thoughts?

Indeed, this has been reported a few times:

  http://bugs.gnu.org/19439

I think we should implement the proposed change.  Could you look
into it?

Thanks,
Ludo’.



  parent reply	other threads:[~2016-01-06 16:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CA+xn8YDemiCuOf569TUfP3XAMKpDhF-JqeymgCU0ntHRorPZsQ@mail.gmail.com>
     [not found] ` <20160104043952.GA29303@jasmine>
     [not found]   ` <CA+xn8YCU5_WizeVShKQ_2LaF-uDAY4H57o_nYjxDRuEv-TkJyQ@mail.gmail.com>
2016-01-04 11:44     ` [PATCH] gnu: Add erlang Andy Wingo
2016-01-04 12:13       ` Nala Ginrut
2016-01-04 12:03         ` tomas
2016-01-06 16:07       ` Ludovic Courtès [this message]
2016-01-07  9:56         ` Andy Wingo
2016-01-07 10:04           ` tomas
2016-06-22 19:42           ` bug#19439: " Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wprmg088.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=19439@debbugs.gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=steve.sprang@gmail.com \
    --cc=wingo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).