From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Arne Babenhauserheide Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add tree-il optimizations for equal? on char and number literals Date: Wed, 13 May 2020 18:33:46 +0200 Message-ID: <87wo5fx09h.fsf@web.de> References: <71bf4755-11b0-4211-abe7-677adc14db76@www.fastmail.com> <8736849bxw.fsf@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="39010"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.4; emacs 26.3 Cc: guile-devel@gnu.org, Linus =?utf-8?Q?Bj=C3=B6rnstam?= To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Wed May 13 18:38:17 2020 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYuOe-000A1p-Vs for guile-devel@m.gmane-mx.org; Wed, 13 May 2020 18:38:16 +0200 Original-Received: from localhost ([::1]:36940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYuOd-0000Ai-OL for guile-devel@m.gmane-mx.org; Wed, 13 May 2020 12:38:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYuKR-0004Wy-T9 for guile-devel@gnu.org; Wed, 13 May 2020 12:33:56 -0400 Original-Received: from mout.web.de ([217.72.192.78]:43053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYuKQ-0002S6-IH for guile-devel@gnu.org; Wed, 13 May 2020 12:33:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1589387627; bh=i/gQKDrkX1ipj2Gb6VvDHHrJud/q2J1TF5SRLR0MVAA=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=eBeIvUKbFprs6boq8IWYc9L0RmXh49h7DXxs33Ed5N3HO+Sq7puOTTmapDsbB8Eew LF6fyGAojmyXrKiwSzxFVXxX+3+BLdG4okGqACgKkdbae5bc2X+XCojP3CJGGlCLZX ZCtcaAHQqcgr8TwdxrFkgUfz2oNkqrigIHnkVKqI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from fluss ([84.165.26.28]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LtFYd-1j7JeD3ZpT-012rHd; Wed, 13 May 2020 18:33:46 +0200 In-reply-to: <8736849bxw.fsf@pobox.com> X-Provags-ID: V03:K1:s6sO89Z6aQOXoppqGbmRL0mpr9UZoqgFYohj3OzmUEg/ECkKm8F +pF42ps56VOajFWJmROh54nSRbdvm4EaR13ushXBQ3jZjWN7Gs44/ZKKR8XAbHrGYLSvfy5 W9AnTt8LDgVpcQUQgqhVxhK+Hn3GW3ZN/97af5FJucOo54G/c6wvUfPH+Ak/jYaiX3+BvVW iNu63/3PmtRbCFx225NYQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZOi3vbYhxS4=:9P2S8VlOAw+N0LMOWF6SWO Z5hYh7mijB7y1uMKNAE7DTpB1zl/2Z6/ZC7HmeFYKXOjpWFK4+gaatV7n3aUaRWyToLmSF3e7 HW1BVll25r6rn4ai7Cj0dcJ7rCP1wgeHWSjo3uMxDCakAk4NLNb3F2Vzz/EjgRe0dhBxoR2tH egeiY2EwbwO+hFNYb8wIqEIhQ9qJdlWs9C8jOMGiOZnQF0jTR4IZAJRLrpIWdD8NqeUwvCuOj yV20ndV3WwrvvMPVN6lA0tn0DnGa5IpGZ7P8dCXbjvHGDLbAB8K9C2dGYZNeYwM9r7omPb0kg fKYPjJanqgdkT/Mesy7/3Ism4tvHOrjXJ5XjQYDK3OvqAflYpX7B9zSo2wmk6YT9UQx0cJ7sS QxguAkKdD3x9/2xp+TfDmDM2eUwPYyfdhwT4wUlm8kJAR7K/7Iud1/ZWhEdzBj9GVeSLPMFvM epgPlwNmmWgTR1dY7+EXJTH9DnQMEESHLTY1ra8t2Q4PVFW0kWFZR2H4AQKWZeLJboNqStGXB hu+nkS8VnxKROhBOsa50dEu47rL5U6+WK7/LZyp1WgS8Syp4X1zxXm8ilCfuUx5X2SRzOp4KL TmelX24fb0e789woyddIsDipEiQWnrx7JRKPLYo6furbtLuFudeTb5ZbwSl1w02hQXY9lMrRg Eo3qFEdNoTzDr/GXPZtHPmfnQLoUly6WyiYPkUEvUyO/3BfifgFRLjpZJAWXJ6hutxKwVT9g+ k1xWBdamv8z2vq7n0kWp2HDG9qlq1GhJ+0UXW8tNlkIkl4Y9oxKYjridnylS4wmiGnVKnafa Received-SPF: pass client-ip=217.72.192.78; envelope-from=arne_bab@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 12:33:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20517 Archived-At: Andy Wingo writes: > This was in the original code but is wrong: if "b" has a side-effect, it > will happen twice. I have fixed it in git. Cool =E2=80=94 thank you! Do you see the difference in your benchmarks? Best wishes, Arne --=20 Unpolitisch sein hei=C3=9Ft politisch sein ohne es zu merken