unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>, "Jonas Hahnfeld" <hahnjo@hahnjo.de>
Cc: guile-devel@gnu.org, 69314@debbugs.gnu.org
Subject: Re: bug#69314: [PATCH] Speed up stage0 bootstrap build using prebuilts
Date: Tue, 07 May 2024 18:21:01 +0200	[thread overview]
Message-ID: <87wmo51tle.fsf@gmail.com> (raw)
In-Reply-To: <878r0nmggm.fsf@gnu.org>

Hi Ludo,

On lun., 06 mai 2024 at 11:34, Ludovic Courtès <ludo@gnu.org> wrote:

>>> -        stage0) GUILE_LOAD_COMPILED_PATH="${top_builddir}/stage0:${top_srcdir}/prebuilt/@SCM_PREBUILT_BINARIES@" ;;
>>> +        stage0) GUILE_LOAD_COMPILED_PATH="${top_srcdir}/prebuilt/@SCM_PREBUILT_BINARIES@:${top_builddir}/stage0" ;;
>
> I don’t understand why changing the order would make a difference.
> Surely if .go files are available under prebuilt/, they’ll be found,
> even if that directory comes second?  Or am I missing something?

Well, depending on what had been built before, it might read:

--8<---------------cut here---------------start------------->8---
$ ls -1 {stage0,prebuilt/x86_64-unknown-linux-gnu}/ice-9/{boot-9,eval,psyntax-pp}.go
prebuilt/x86_64-unknown-linux-gnu/ice-9/boot-9.go
prebuilt/x86_64-unknown-linux-gnu/ice-9/eval.go
prebuilt/x86_64-unknown-linux-gnu/ice-9/psyntax-pp.go
stage0/ice-9/boot-9.go
stage0/ice-9/eval.go
stage0/ice-9/psyntax-pp.go
--8<---------------cut here---------------end--------------->8---

Therefore, the order in GUILE_LOAD_COMPILED_PATH matters, no?

Somehow, similarly as:

        stage1) GUILE_LOAD_COMPILED_PATH="${top_builddir}/stage1:${top_builddir}/stage0" ;;

I would set the expected most optimized first, such that:

        stage0) GUILE_LOAD_COMPILED_PATH="${top_srcdir}/prebuilt/@SCM_PREBUILT_BINARIES@:${top_builddir}/stage0" ;;

assuming ’prebuilt’ provides something more optimized than ’stage0’.


Cheers,
simon



      parent reply	other threads:[~2024-05-07 16:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 10:57 [PATCH] Speed up stage0 bootstrap build using prebuilts Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-02-22 20:09 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-05-06  9:34   ` bug#69314: " Ludovic Courtès
2024-05-06 19:12     ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-05-07 16:21     ` Simon Tournier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmo51tle.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=69314@debbugs.gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=hahnjo@hahnjo.de \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).