From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.lisp.guile.devel Subject: scm_i_init_rstate vs gcc-3.4 Date: Mon, 24 Jan 2005 10:57:18 +1100 Message-ID: <87vf9nitr5.fsf@zip.com.au> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1106526248 1002 80.91.229.6 (24 Jan 2005 00:24:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 24 Jan 2005 00:24:08 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jan 24 01:23:45 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Css19-0001pZ-00 for ; Mon, 24 Jan 2005 01:23:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CssDK-0003ME-AE for guile-devel@m.gmane.org; Sun, 23 Jan 2005 19:36:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CssBt-0002lP-Mz for guile-devel@gnu.org; Sun, 23 Jan 2005 19:34:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1CssBs-0002kh-8v for guile-devel@gnu.org; Sun, 23 Jan 2005 19:34:48 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Css86-00016a-CH for guile-devel@gnu.org; Sun, 23 Jan 2005 19:30:54 -0500 Original-Received: from [61.8.0.84] (helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Csrbm-0000D9-9o for guile-devel@gnu.org; Sun, 23 Jan 2005 18:57:30 -0500 Original-Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (8.12.3/8.12.3/Debian-7.1) with ESMTP id j0NNvRA6009408 for ; Mon, 24 Jan 2005 10:57:27 +1100 Original-Received: from localhost (ppp2A47.dyn.pacific.net.au [61.8.42.71]) by mailproxy2.pacific.net.au (8.12.3/8.12.3/Debian-7.1) with ESMTP id j0NNvP8v025343 for ; Mon, 24 Jan 2005 10:57:26 +1100 Original-Received: from gg by localhost with local (Exim 3.36 #1 (Debian)) id 1Csrba-0002G4-00; Mon, 24 Jan 2005 10:57:18 +1100 Original-To: guile-devel@gnu.org Mail-Copies-To: never User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.devel:4733 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:4733 --=-=-= Someone who knows what this bit of code is meant to be doing can check: * random.c (scm_i_init_rstate): Compare w to -1 not 0xffffffffUL, now that it's an scm_t_int32. Otherwise gcc 3.4 says it's always false on a 64-bit system. (This gcc complaint is a warning, but warnings are made fatal of course.) --=-=-= Content-Disposition: inline; filename=random.c.w.diff --- random.c.~1.74.~ 2005-01-18 09:01:28.000000000 +1100 +++ random.c 2005-01-24 10:53:24.000000000 +1100 @@ -133,7 +133,7 @@ else c += seed[i] << (8 * (m - 4)); } - if ((w == 0 && c == 0) || (w == 0xffffffffUL && c == A - 1)) + if ((w == 0 && c == 0) || (w == -1 && c == A - 1)) ++c; state->w = w; state->c = c; --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel --=-=-=--