unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
* scm_i_init_rstate vs gcc-3.4
@ 2005-01-23 23:57 Kevin Ryde
  0 siblings, 0 replies; only message in thread
From: Kevin Ryde @ 2005-01-23 23:57 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

Someone who knows what this bit of code is meant to be doing can
check:

        * random.c (scm_i_init_rstate): Compare w to -1 not 0xffffffffUL, now
        that it's an scm_t_int32.  Otherwise gcc 3.4 says it's always false on
        a 64-bit system.

(This gcc complaint is a warning, but warnings are made fatal of
course.)


[-- Attachment #2: random.c.w.diff --]
[-- Type: text/plain, Size: 347 bytes --]

--- random.c.~1.74.~	2005-01-18 09:01:28.000000000 +1100
+++ random.c	2005-01-24 10:53:24.000000000 +1100
@@ -133,7 +133,7 @@
       else
         c += seed[i] << (8 * (m - 4));
     }
-  if ((w == 0 && c == 0) || (w == 0xffffffffUL && c == A - 1))
+  if ((w == 0 && c == 0) || (w == -1 && c == A - 1))
     ++c;
   state->w = w;
   state->c = c;

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-01-23 23:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-23 23:57 scm_i_init_rstate vs gcc-3.4 Kevin Ryde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).