From: Kevin Ryde <user42@zip.com.au>
Subject: scm_i_init_rstate vs gcc-3.4
Date: Mon, 24 Jan 2005 10:57:18 +1100 [thread overview]
Message-ID: <87vf9nitr5.fsf@zip.com.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
Someone who knows what this bit of code is meant to be doing can
check:
* random.c (scm_i_init_rstate): Compare w to -1 not 0xffffffffUL, now
that it's an scm_t_int32. Otherwise gcc 3.4 says it's always false on
a 64-bit system.
(This gcc complaint is a warning, but warnings are made fatal of
course.)
[-- Attachment #2: random.c.w.diff --]
[-- Type: text/plain, Size: 347 bytes --]
--- random.c.~1.74.~ 2005-01-18 09:01:28.000000000 +1100
+++ random.c 2005-01-24 10:53:24.000000000 +1100
@@ -133,7 +133,7 @@
else
c += seed[i] << (8 * (m - 4));
}
- if ((w == 0 && c == 0) || (w == 0xffffffffUL && c == A - 1))
+ if ((w == 0 && c == 0) || (w == -1 && c == A - 1))
++c;
state->w = w;
state->c = c;
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
reply other threads:[~2005-01-23 23:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vf9nitr5.fsf@zip.com.au \
--to=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).