Re: Terrific Dead Lock

[Neil Jerram <neil@ossau.uklinux.net>]

ludo@gnu.org (Ludovic Courtès) writes:

> Hi,
>
> Neil Jerram <neil@ossau.uklinux.net> writes:
>
>> Basically yes, but two thoughts:
>>
>> - Can I just take a couple more days to review the srcprops changes in
>>   detail?  It's important for my debugging work, and I recall having
>>   some concern when Han-Wen implemented this...  Looking at the diffs
>>   quickly again now, I can't see any reason for that concern, but I'd
>>   like to be sure.
>>
>> - Although I agree in principle that all those macros shouldn't be in
>>   srcprop.h, do we really need to make that change now?  I think we can
>>   just apply Han-Wen's changes to the macros in srcprop.h, without
>>   moving them to srcprop.c.
>
> Are you OK to apply the patch?

Yes, fine.  Sorry for forgetting about this.

(I wonder if SCM_CDR (scm_last_plist_filename) on one thread is
guaranteed to give a sane value, if there is another thread
simultaneously doing SCM_SETCDR (scm_last_plist_filename) - but I'm
not an expert in this kind of thing.)

Regards,
      Neil