From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-2-164-g0d05ae7 Date: Wed, 09 Sep 2009 09:42:09 +0200 Message-ID: <87vdjso97y.fsf@gnu.org> References: <87fxaxavog.fsf@gnu.org> <1252469794.24639.20.camel@localhost.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1252482170 4664 80.91.229.12 (9 Sep 2009 07:42:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Sep 2009 07:42:50 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Sep 09 09:42:43 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MlHpC-0003w3-Se for guile-devel@m.gmane.org; Wed, 09 Sep 2009 09:42:43 +0200 Original-Received: from localhost ([127.0.0.1]:43530 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlHpC-0005uM-Bg for guile-devel@m.gmane.org; Wed, 09 Sep 2009 03:42:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MlHp9-0005uF-Ab for guile-devel@gnu.org; Wed, 09 Sep 2009 03:42:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MlHp4-0005tv-Lm for guile-devel@gnu.org; Wed, 09 Sep 2009 03:42:38 -0400 Original-Received: from [199.232.76.173] (port=40925 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlHp4-0005ts-Hs for guile-devel@gnu.org; Wed, 09 Sep 2009 03:42:34 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:9280) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MlHp4-0002WG-2s for guile-devel@gnu.org; Wed, 09 Sep 2009 03:42:34 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MlHp3-0001aI-Ah for guile-devel@gnu.org; Wed, 09 Sep 2009 03:42:33 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1MlHp1-0003sW-Tt for guile-devel@gnu.org; Wed, 09 Sep 2009 09:42:31 +0200 Original-Received: from laptop-147-210-128-170.labri.fr ([147.210.128.170]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Sep 2009 09:42:31 +0200 Original-Received: from ludo by laptop-147-210-128-170.labri.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Sep 2009 09:42:31 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 70 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: laptop-147-210-128-170.labri.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 Fructidor an 217 de la =?iso-8859-1?Q?R=E9volutio?= =?iso-8859-1?Q?n?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Cancel-Lock: sha1:D5Kh78EDrxvIFIJ4h4Qrro9Y8dQ= X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9287 Archived-At: Hi, Mike Gran writes: > On Wed, 2009-09-09 at 01:00 +0200, Ludovic Courtès wrote: [...] >> > - return scm_getc (input_port); >> > + return scm_get_byte_or_eof (input_port); >> >> This is actually an earlier change, but the prototype of scm_getc is now >> different from that in 1.8. Presumably, this means that it’s not >> source-compatible with 1.8, e.g., on platforms where >> sizeof (int) < sizeof (scm_t_wchar), right? I was actually referring to the fact that 1.8 has: SCM_API int scm_getc (SCM port); whereas 1.9 has: SCM_API scm_t_wchar scm_getc (SCM port); What do you think? >> > --- a/libguile/strings.h >> > +++ b/libguile/strings.h >> > @@ -111,7 +111,7 @@ SCM_API SCM scm_substring_shared (SCM str, SCM start, SCM end); >> > SCM_API SCM scm_substring_copy (SCM str, SCM start, SCM end); >> > SCM_API SCM scm_string_append (SCM args); >> > >> > -SCM_INTERNAL SCM scm_i_from_stringn (const char *str, size_t len, >> > +SCM_API SCM scm_i_from_stringn (const char *str, size_t len, >> > const char *encoding, >> > scm_t_string_failed_conversion_handler >> > handler); >> > @@ -157,7 +157,7 @@ SCM_INTERNAL const scm_t_wchar *scm_i_string_wide_chars (SCM str); >> > SCM_INTERNAL SCM scm_i_string_start_writing (SCM str); >> > SCM_INTERNAL void scm_i_string_stop_writing (void); >> > SCM_INTERNAL int scm_i_is_narrow_string (SCM str); >> > -SCM_INTERNAL scm_t_wchar scm_i_string_ref (SCM str, size_t x); >> > +SCM_API scm_t_wchar scm_i_string_ref (SCM str, size_t x); >> >> Were these changes intended? > > Well, one of the two of them was intended. :) Shouldn’t both of them remain internal given that they have an ‘_i_’ in their name? >> > + (with-locale "en_US.iso88591" >> > + (pass-if-exception "no args" exception:wrong-num-args >> > + (regexp-quote)) >> >> Is the locale part of the API? That is, should programs that use >> regexps explicitly ask for a locale with 8-bit encoding? > > Basically yes. The libc regex is 8-bit, and it uses > scm_to/from_locale_string to convert regex's input and output. That’s unfortunate but OTOH it’s the same as in 1.8, so I guess it’s OK. > Until libunistring comes with Unicode regex, I think this is the best we > can do. Yes, that would be neat! Thanks, Ludo’.