From: Andy Wingo <wingo@pobox.com>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: The dynamic stack
Date: Tue, 06 Mar 2012 21:32:57 +0100 [thread overview]
Message-ID: <87vcmh1nd2.fsf@pobox.com> (raw)
In-Reply-To: <87k42xabo2.fsf@gnu.org> ("Ludovic Courtès"'s message of "Tue, 06 Mar 2012 18:20:45 +0100")
Greets :)
On Tue 06 Mar 2012 18:20, ludo@gnu.org (Ludovic Courtès) writes:
> Andy Wingo <wingo@pobox.com> skribis:
>
>> I have pushed a patch to master that changes the implementation of the
>> dynamic stack
>
> The “dynwind stack” actually (I misread it the first time.)
Yes, it did have this name before. (More often, "the wind list".) But
since "dynwind" is overloaded so much (dynamic-wind operator, <dynwind>,
scm_dynwind_*), and the dynamic stack can have other things on it like
prompts, I thought it best to give it a new name.
> Could you please add comments in dynstack.c (above each function), and
> make sure to follow GCS-style (no hanging brace, for example)?
What do you mean by "no hanging brace"? To my knowledge^Wignorance this
file does have the right style.
What sorts of comments would you like to see? I have been working with
this code a lot, so perhaps some things which are obvious to me from
names, types, assertions, etc that might not actually be obvious. I
don't see what I can write that isn't wholly redundant. Perhaps you
will let me know :-)
Regards,
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2012-03-06 20:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 16:25 The dynamic stack Andy Wingo
2012-03-06 17:20 ` Ludovic Courtès
2012-03-06 20:32 ` Andy Wingo [this message]
2012-03-07 6:05 ` Noah Lavine
2012-03-07 9:51 ` Andy Wingo
2012-03-07 23:09 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcmh1nd2.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).