From: ludo@gnu.org (Ludovic Courtès)
To: Mike Gran <spk121@yahoo.com>
Cc: Andy Wingo <wingo@pobox.com>, Mark H Weaver <mhw@netris.org>,
"guile-devel@gnu.org" <guile-devel@gnu.org>
Subject: Re: [PATCH] Improve handling of Unicode byte-order marks (BOMs)
Date: Fri, 05 Apr 2013 12:04:00 +0200 [thread overview]
Message-ID: <87vc81z433.fsf@gnu.org> (raw)
In-Reply-To: <1365147746.81118.YahooMailNeo@web120403.mail.ne1.yahoo.com> (Mike Gran's message of "Fri, 5 Apr 2013 00:42:26 -0700 (PDT)")
Mike Gran <spk121@yahoo.com> skribis:
>>>> + /* If the specified encoding is UTF-16 or UTF-32, then make
>>>> + that more precise by deciding what endianness to use. */
>>>> + if (strcasecmp (pt->encoding, "UTF-16") == 0)
>>>> + precise_encoding = decide_utf16_encoding (port, mode);
>>>> + else if (strcasecmp (pt->encoding, "UTF-32") == 0)
>>>> + precise_encoding = decide_utf32_encoding (port, mode);
>>>
>>> Ideally these comparisons would not be locale-dependent. Dunno.
>>
>> Yes, that would be preferable. We talked about adding an
>> 'ascii_strcasecmp' function. What file do you think it should be
>> defined in?
>
> It would be a trivial function to write, of course, but there is a
> c-strcasecmp func in gnulib.
Yes, better use that one.
(Just add ‘c-strcase’ in m4/gnulib-cache.m4, run ‘gnulib-tool --update’
with Gnulib v0.0-7865-ga828bb2, and git add the new files.)
Ludo’.
next prev parent reply other threads:[~2013-04-05 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 10:44 [PATCH] Improve handling of Unicode byte-order marks (BOMs) Mark H Weaver
2013-04-03 11:47 ` Mark H Weaver
2013-04-03 11:58 ` Ludovic Courtès
2013-04-03 19:28 ` Mark H Weaver
2013-04-03 20:11 ` Ludovic Courtès
2013-04-03 20:33 ` Mark H Weaver
2013-04-03 20:48 ` Mike Gran
2013-04-03 22:24 ` Mark H Weaver
2013-04-04 5:59 ` Mark H Weaver
2013-04-04 20:50 ` Andy Wingo
2013-04-05 7:30 ` Mark H Weaver
2013-04-05 7:42 ` Mike Gran
2013-04-05 10:04 ` Ludovic Courtès [this message]
2013-04-05 18:15 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc81z433.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
--cc=spk121@yahoo.com \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).