From: David Michael <fedora.dm0@gmail.com>
To: guile-devel@gnu.org
Subject: [PATCH] guile-readline: Use an empty string if HOME is unset
Date: Tue, 09 Sep 2014 17:28:42 -0400 [thread overview]
Message-ID: <87vbowa3g5.fsf@gmail.com> (raw)
* guile-readline/ice-9/readline.scm (history-file): When the HOME
environment variable is unset, use the empty string in its place.
---
Hi,
If a Guile program uses the readline module without setting HOME, it
will fail due to string-append getting a #f argument. In particular,
this necessitates workarounds when starting GNU dmd early in the boot
process. To illustrate this, try:
guile -c '(use-modules (ice-9 readline))(display "working\n")'
And then:
env -u HOME \
guile -c '(use-modules (ice-9 readline))(display "working\n")'
Let me know if there is a better alternative for handling this case, and
I can send another patch.
Thanks.
David
guile-readline/ice-9/readline.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/guile-readline/ice-9/readline.scm b/guile-readline/ice-9/readline.scm
index 02e68af..0979fd3 100644
--- a/guile-readline/ice-9/readline.scm
+++ b/guile-readline/ice-9/readline.scm
@@ -119,7 +119,8 @@
(define-once the-readline-port #f)
(define-once history-variable "GUILE_HISTORY")
-(define-once history-file (string-append (getenv "HOME") "/.guile_history"))
+(define-once history-file
+ (string-append (or (getenv "HOME") "") "/.guile_history"))
(define-public readline-port
(let ((do (lambda (r/w)
--
1.9.3
next reply other threads:[~2014-09-09 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 21:28 David Michael [this message]
2014-09-10 17:00 ` [PATCH] guile-readline: Use an empty string if HOME is unset Eli Zaretskii
2014-09-10 18:06 ` David Michael
2014-09-10 18:23 ` Eli Zaretskii
2014-09-22 3:38 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbowa3g5.fsf@gmail.com \
--to=fedora.dm0@gmail.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).