From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add GNU-style error location for failing tests in test-suite. v3 Date: Wed, 29 Oct 2014 17:40:20 -0400 Message-ID: <87vbn2o8qj.fsf@yeeloong.lan> References: <87wq8uffw9.fsf@drakenvlieg.flower> <87sij2j1x4.fsf@drakenvlieg.flower> <87fvf2gpq6.fsf_-_@drakenvlieg.flower> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1414618991 3701 80.91.229.3 (29 Oct 2014 21:43:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 29 Oct 2014 21:43:11 +0000 (UTC) Cc: guile-devel To: Jan Nieuwenhuizen Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Oct 29 22:43:04 2014 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xjb1D-0001dE-BV for guile-devel@m.gmane.org; Wed, 29 Oct 2014 22:43:03 +0100 Original-Received: from localhost ([::1]:49198 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xjb1C-0008NT-V6 for guile-devel@m.gmane.org; Wed, 29 Oct 2014 17:43:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xjb14-0008Ku-In for guile-devel@gnu.org; Wed, 29 Oct 2014 17:43:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xjazu-0006DQ-8J for guile-devel@gnu.org; Wed, 29 Oct 2014 17:42:54 -0400 Original-Received: from world.peace.net ([96.39.62.75]:52573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xjazu-0006Av-4X; Wed, 29 Oct 2014 17:41:42 -0400 Original-Received: from turntable.mit.edu ([18.160.0.29] helo=yeeloong.lan) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Xjazd-0005Ml-2U; Wed, 29 Oct 2014 17:41:25 -0400 In-Reply-To: <87fvf2gpq6.fsf_-_@drakenvlieg.flower> (Jan Nieuwenhuizen's message of "Sun, 05 Oct 2014 23:40:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 96.39.62.75 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:17598 Archived-At: Hi Jan, Jan Nieuwenhuizen writes: > > Changes in v3: > > * fix source-line/user-source-line confusion in srfi-64 > * better conforming commit message Did you try running "make check" with this patch applied? I found that there were well over a hundred other uses of 'run-test' in the test-suite directory that you didn't update. Also, can you try to keep lines to 80 columns max? Thanks! Mark