unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] Add GNU-style error location for failing tests in test-suite. v3
Date: Wed, 29 Oct 2014 17:40:20 -0400	[thread overview]
Message-ID: <87vbn2o8qj.fsf@yeeloong.lan> (raw)
In-Reply-To: <87fvf2gpq6.fsf_-_@drakenvlieg.flower> (Jan Nieuwenhuizen's message of "Sun, 05 Oct 2014 23:40:17 +0200")

Hi Jan,

Jan Nieuwenhuizen <janneke@gnu.org> writes:
>
> Changes in v3:
>
>   * fix source-line/user-source-line confusion in srfi-64
>   * better conforming commit message

Did you try running "make check" with this patch applied?  I found
that there were well over a hundred other uses of 'run-test' in the
test-suite directory that you didn't update.

Also, can you try to keep lines to 80 columns max?

     Thanks!
       Mark



  reply	other threads:[~2014-10-29 21:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 16:41 [PATCH] Add GNU-style error location for failing tests in test-suite Jan Nieuwenhuizen
2014-10-05  9:33 ` [PATCH] Add GNU-style error location for failing tests in test-suite. v2 Jan Nieuwenhuizen
2014-10-05 21:40   ` [PATCH] Add GNU-style error location for failing tests in test-suite. v3 Jan Nieuwenhuizen
2014-10-29 21:40     ` Mark H Weaver [this message]
2014-12-07  8:41       ` Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbn2o8qj.fsf@yeeloong.lan \
    --to=mhw@netris.org \
    --cc=guile-devel@gnu.org \
    --cc=janneke@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).