From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Rob Browning Newsgroups: gmane.lisp.guile.devel Subject: Re: setgroups Date: Thu, 17 Apr 2003 22:34:13 -0500 Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Message-ID: <87u1cwcwcq.fsf@raven.i.defaultvalue.org> References: <87brz4dagq.fsf@raven.i.defaultvalue.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1050637048 19733 80.91.224.249 (18 Apr 2003 03:37:28 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 18 Apr 2003 03:37:28 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Apr 18 05:37:26 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 196MgZ-00057e-00 for ; Fri, 18 Apr 2003 05:37:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 196Mgl-0001kx-00 for guile-devel@m.gmane.org; Thu, 17 Apr 2003 23:37:23 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 196Mfb-0000oT-00 for guile-devel@gnu.org; Thu, 17 Apr 2003 23:36:11 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 196Me4-00008J-00 for guile-devel@gnu.org; Thu, 17 Apr 2003 23:34:37 -0400 Original-Received: from dsl093-098-016.wdc1.dsl.speakeasy.net ([66.93.98.16] helo=defaultvalue.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 196Mdh-0008Dh-00 for guile-devel@gnu.org; Thu, 17 Apr 2003 23:34:13 -0400 Original-Received: from raven.i.defaultvalue.org (raven.i.defaultvalue.org [192.168.1.7]) by defaultvalue.org (Postfix) with ESMTP id 563F2D98 for ; Thu, 17 Apr 2003 22:34:13 -0500 (CDT) Original-Received: by raven.i.defaultvalue.org (Postfix, from userid 1000) id 3680B21521B; Thu, 17 Apr 2003 22:34:13 -0500 (CDT) Original-To: guile-devel@gnu.org In-Reply-To: (prj@po.cwru.edu's message of "Thu, 17 Apr 2003 19:20:12 -0400") User-Agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.2 (i386-pc-linux-gnu) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Developers list for Guile, the GNU extensibility library List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.devel:2182 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:2182 prj@po.cwru.edu (Paul Jarc) writes: > Ok, here's a patch for setgroups. It's my first time writing Guile C > code, so someone should check it carefully. I used a vector argument > just because that's what getgroups returns. That sounds about right... > + ngroups = SCM_VECTOR_LENGTH (group_vec); > + size = ngroups * sizeof (GETGROUPS_T); > + groups = scm_malloc (size); > + for(i = ngroups; i >= 0; i--) > + groups [i] = SCM_INUM (SCM_VECTOR_REF (group_vec, i)); > + > + result = setgroups (ngroups, groups); > + free (groups); I might add a scm_remember_upto_here_1 (group_vec); here just to be safe, but that might be overkill, depending on what SCM_VECTOR_REF does. > + if (result < 0) > + SCM_SYSERROR; > + return SCM_UNSPECIFIED; > +} Overall, it looks good to me. -- Rob Browning rlb @defaultvalue.org, @linuxdevel.com, and @debian.org Previously @cs.utexas.edu GPG starting 2002-11-03 = 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://mail.gnu.org/mailman/listinfo/guile-devel