scm_done_malloc negatives [1.6]

scm_done_malloc negatives [1.6]

[Kevin Ryde]

In the 1.6 branch, scm_done_malloc has a bit of code,

  if (size < 0) {
    if (scm_mallocated < size)
      /* The byte count of allocated objects has underflowed.  This is
         probably because you forgot to report the sizes of objects you
         have allocated, by calling scm_done_malloc or some such.  When
         the GC freed them, it subtracted their size from
         scm_mallocated, which underflowed.  */
      abort ();


This looks slightly suspicious, since scm_mallocated is a ulong.  I
wonder if it's meant to be "-size" in the comparison?


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

Re: scm_done_malloc negatives [1.6]

[Rob Browning]

Kevin Ryde <user42@zip.com.au> writes:

> This looks slightly suspicious, since scm_mallocated is a ulong.  I
> wonder if it's meant to be "-size" in the comparison?

>From my reading of the code, that's exactly right.  I've fixed it and
will commit shortly.

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 8C7E 73A4


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel