From: Andy Wingo <wingo@pobox.com>
To: Mark H Weaver <mhw@netris.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Improve support for source properties
Date: Wed, 15 Feb 2012 23:31:49 +0100 [thread overview]
Message-ID: <87ty2rlodm.fsf@pobox.com> (raw)
In-Reply-To: <87r4xw2dgx.fsf@netris.org> (Mark H. Weaver's message of "Wed, 15 Feb 2012 12:50:06 -0500")
On Wed 15 Feb 2012 18:50, Mark H Weaver <mhw@netris.org> writes:
> Here's another patch set to improve support for source properties.
LGTM in general. A few questions to address now or later; I'm fine with
pushing as is.
On the broad side, does the current "source-properties" mechanism make
sense? I get the feeling that a variant of `read' that returned
annotated objects would be better in many ways. Perhaps that is an
orthogonal question though. For prior art, see Racket's read-syntax:
http://docs.racket-lang.org/reference/Reading.html#(def._((quote._~23~25kernel)._read-syntax))
> * add the 'supports-source-properties?' predicate (as well as
> scm_supports_source_properties_p), which cannot be implemented
> efficiently in Scheme.
What do you think about a name like `unique-datum?'? It's uniqueness
(in the eq? sense) that is the thing, right?
> * psyntax now accesses and sets source properties for all supported
> objects. Previously it assumed that only pairs could support source
> properties.
Do check to see that the result of
,time (compile-file "module/ice-9/psyntax.scm")
is not too badly affected.
Cheers,
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2012-02-15 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 17:50 [PATCH] Improve support for source properties Mark H Weaver
2012-02-15 22:31 ` Andy Wingo [this message]
2012-02-16 21:45 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty2rlodm.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).