From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: build-lexical-var vs. -Wunused-variable Date: Fri, 17 Feb 2012 12:00:50 +0100 Message-ID: <87ty2p4tct.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1329476474 12588 80.91.229.3 (17 Feb 2012 11:01:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 17 Feb 2012 11:01:14 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Feb 17 12:01:13 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RyLYv-0001u3-Iz for guile-devel@m.gmane.org; Fri, 17 Feb 2012 12:01:13 +0100 Original-Received: from localhost ([::1]:47188 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyLYv-0004ds-1O for guile-devel@m.gmane.org; Fri, 17 Feb 2012 06:01:13 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:34555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyLYo-0004dl-CX for guile-devel@gnu.org; Fri, 17 Feb 2012 06:01:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyLYk-0001PM-Fj for guile-devel@gnu.org; Fri, 17 Feb 2012 06:01:06 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:49136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyLYk-0001PA-Af for guile-devel@gnu.org; Fri, 17 Feb 2012 06:01:02 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1RyLYh-0001gU-Up for guile-devel@gnu.org; Fri, 17 Feb 2012 12:00:59 +0100 Original-Received: from 193.50.110.167 ([193.50.110.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 17 Feb 2012 12:00:59 +0100 Original-Received: from ludo by 193.50.110.167 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 17 Feb 2012 12:00:59 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 34 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 193.50.110.167 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?iso-8859-1?Q?Pluvi=F4se?= an 220 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.93 (gnu/linux) Cancel-Lock: sha1:9c7BDHIh6qWFArQPI391n8Bvg4U= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:13885 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hello, Commit f9685f437312ea790981373ddc375b2a26ba9c4f changes ‘build-lexical-var’ like this: --=-=-= Content-Type: text/x-patch Content-Disposition: inline (define-syntax-rule (build-lexical-var src id) - (gensym (string-append (symbol->string id) " "))) + (gensym (string-append (symbol->string id) "-"))) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit This breaks a heuristic used in the ‘unused-variable’ pass, which is that identifiers containing white space are likely introduced by a macro and can be ignored in unused-variable reports (see ‘gensym?’ in ‘tree-il/analyze.scm’). OK to change it back? Thanks, Ludo’. --=-=-=--