Re: Support open-process and friends on MS-Windows

[ludo@gnu.org (Ludovic Courtès)]

Eli Zaretskii <eliz@gnu.org> skribis:

>> From: Andy Wingo <wingo@pobox.com>
>> Cc: ludo@gnu.org,  guile-devel@gnu.org
>> Date: Sat, 25 Jun 2016 11:51:53 +0200
>> 
>> On Sat 25 Jun 2016 11:11, Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > Here's the modified patch with the couple of changes requested in
>> > response to the previous version:
>> 
>> Great!  I have two nits.  One, if it is possible for you, please attach
>> the patch in the format that "git format-patch" makes.  That makes it
>> easy to apply, otherwise I have to futz around with --author and I could
>> accidentally fat-finger it and get it wrong.
>> 
>> Secondly, please make w32-proc override the definitions of
>> HAVE_GETPRIORITY, HAVE_SETPRIORITY, HAVE_SCHED_GETAFFINITY, and
>> HAVE_SCHED_SETAFFINITY.  That way you won't need this kind of change
>> either:
>> 
>> > -#if HAVE_GETPRIORITY
>> > +#if HAVE_GETPRIORITY || defined __MINGW32__
>> 
>> If you've already discussed this with Ludovic and decided to go this way
>> explicitly, please disregard this second nit.
>> 
>> I will also wait a day or two for any comments from Ludovic before
>> applying.
>
> Thanks, I will wait for Ludovic to tell he's okay with overriding the
> HAVE_* macros,

Yes, I agree with Andy, I think it’ll be nicer.

> and will send a format-patch formatted changes after that.

Cool, thank you!

Ludo’.