From: Marius Vollmer <mvo@zagadka.de>
Cc: guile-devel@gnu.org
Subject: Re: guile 1.8 and x86_64
Date: 08 May 2006 00:29:32 +0300 [thread overview]
Message-ID: <87slnljzgj.fsf@minimini.mvo.home> (raw)
In-Reply-To: <20060506111221.GA16844@bordell.redhat.usu>
Miroslav Lichvar <mlichvar@redhat.com> writes:
> On Fri, May 05, 2006 at 04:05:34PM +0200, Miroslav Lichvar wrote:
> > The scm_mark_locations function in gc-mark.c calls scm_gc_mark on
> > everything located in one of the allocated segments. Shouldn't there
> > be a check if the address is at least scm_t_cell aligned?
Yes! I haven't really seen the 64bit problem myself, but you theory
sounds very convincing. This is very likely the solution.
What about this this patch, tho, which is exactly the same as yours,
but a bit more similar to the code we have:
137c137
< #define CELL_P(x) (SCM_ITAG3 (x) == scm_tc3_cons)
---
> #define CELL_P(x) ((SCM_UNPACK(x) & (sizeof(scm_t_cell)-1)) == scm_tc3_cons)
I'll put it in right away, with a comment.
Thanks a 18446744073709551616!
--
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2006-05-07 21:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 19:40 guile 1.8 and x86_64 Quanah Gibson-Mount
2006-04-10 8:14 ` Ludovic Courtès
2006-04-10 22:55 ` Neil Jerram
2006-04-10 23:03 ` Quanah Gibson-Mount
2006-04-11 20:37 ` Neil Jerram
2006-04-11 20:52 ` Quanah Gibson-Mount
2006-05-05 14:05 ` Miroslav Lichvar
2006-05-06 11:12 ` Miroslav Lichvar
2006-05-07 21:29 ` Marius Vollmer [this message]
2006-05-08 10:28 ` Andy Wingo
2006-05-08 21:52 ` Marius Vollmer
2006-05-09 6:49 ` Neil Jerram
2006-05-09 13:23 ` Andy Wingo
2006-05-09 22:31 ` Default stack limit Marius Vollmer
2006-05-10 14:31 ` Andy Wingo
2006-05-10 23:58 ` Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87slnljzgj.fsf@minimini.mvo.home \
--to=mvo@zagadka.de \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).