From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: Pkgsrc patches: patch-ag Date: Mon, 18 Feb 2008 16:05:56 +0100 Message-ID: <87skzqnw2z.fsf@gnu.org> References: <87tzketg12.fsf@gnu.org> <87y79puca8.fsf@ossau.uklinux.net> <87prv0sixe.fsf@inbox.ru> <87ejbg0yhj.fsf@ambire.localdomain> <87odajqv8s.fsf@inbox.ru> <87ir0r9yrb.fsf_-_@gnu.org> <87pruwln04.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1203347251 20171 80.91.229.12 (18 Feb 2008 15:07:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Feb 2008 15:07:31 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Feb 18 16:07:55 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JR7Zt-0005tg-A8 for guile-devel@m.gmane.org; Mon, 18 Feb 2008 16:06:45 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JR7ZO-00087E-Jx for guile-devel@m.gmane.org; Mon, 18 Feb 2008 10:06:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JR7ZL-00083w-Gy for guile-devel@gnu.org; Mon, 18 Feb 2008 10:06:11 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JR7ZJ-0007z7-UB for guile-devel@gnu.org; Mon, 18 Feb 2008 10:06:11 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JR7ZJ-0007yw-Pm for guile-devel@gnu.org; Mon, 18 Feb 2008 10:06:09 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JR7ZJ-000488-7a for guile-devel@gnu.org; Mon, 18 Feb 2008 10:06:09 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JR7ZC-0005iS-Sc for guile-devel@gnu.org; Mon, 18 Feb 2008 15:06:03 +0000 Original-Received: from 193.50.110.98 ([193.50.110.98]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 Feb 2008 15:06:02 +0000 Original-Received: from ludo by 193.50.110.98 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 Feb 2008 15:06:02 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 58 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 193.50.110.98 X-Revolutionary-Date: 30 =?iso-8859-1?Q?Pluvi=F4se?= an 216 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEB1F5364 X-PGP-Key: http://www.laas.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: i686-pc-linux-gnu User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) Cancel-Lock: sha1:X2Esh2syH2ecQZtnrAJPMWusw6k= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7026 Archived-At: Hi, Greg Troxel writes: > ludo@gnu.org (Ludovic Courtès) writes: > >> Greg Troxel writes: >> >>> Fix for solaris, but I thinh preserves behavior on C99 machines. >>> >>> $NetBSD: patch-ag,v 1.5 2007/07/20 00:09:22 gdt Exp $ >>> >>> solaris-2.9 does not have stdint.h but does have inttypes.h >>> >>> --- libguile/c-tokenize.c.orig 2007-06-13 18:00:56.000000000 -0400 >>> +++ libguile/c-tokenize.c >>> @@ -39,7 +39,12 @@ >>> #define __STDC_LIMIT_MACROS 1 >>> #endif >>> >>> +#ifdef HAVE_STDINT_H >>> +#include /* May break IA64 test-noansi-r */ >>> +#else >>> #include >>> +#endif >> >> First, the comment and the patch are contradictory. A bit of googling >> seems to confirm the comment, in which case the patch isn't needed. >> >> Second, C99 requires both (Sections 7.18 and 7.8). >> >> Third, the `#include' is within a `#if __STDC_VERSION__ >= 199901L', so >> only C99 systems get to include it. >> >> Fourth, this is a Flex-generated file, so it'd be nice to avoid patching >> it. >> >> Just to say that I'm dubious about this patch. :-) > > I think the issue is that some versions of solaris do not have stdint.h, > but do have inttypes.h. But, the patch may be wrong in dealing with it. Without the patch, `c-tokenize.c' includes *only* (see my first comment above.) > Does guile have a position on supporting systems that don't conform to > C99? I'm wondering if I should try to figure this out and get a fix > that is reasonable (I agree this one is gross and likely wrong), or just > punt. Guile is written using C89 code. It does use C99 headers when available, but does not usually rely on them I think. I believe the "position" is roughly to be portable to any platform with Guile users. :-) Thanks, Ludovic.