unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: Cleanup mark-during-GC debug checks.
Date: Tue, 09 Sep 2008 19:34:39 +0200	[thread overview]
Message-ID: <87sks9i5ow.fsf@gnu.org> (raw)
In-Reply-To: 00163630f0ef5b47e60456777f02@google.com

Hello!

hanwenn@gmail.com writes:

> Reviewers: hanwenn,
>
> Message:
> Hello guile devel,
>
> please go to
>
> http://codereview.appspot.com/4847
>
> to review this patch.
>
>
> I hope you like it; thanks!

A couple of notes:

  1. I don't want to use a web interface to review code.  Most free
     software projects use email in one form or another, which I find
     convenient.  Having patches in-lined is optimal IMO.

  2. I don't want to have a Google account.

Thus, I'll comment on the patch here.

  * I'd name the macro `SCM_DEBUG_MARK_PHASE' rather, as it sounds mot
    idiomatic (but I'm not a native speaker).

  * Use "static const char msg[] = ...".

Other than that, I'm OK to commit it.

Thanks,
Ludo'.





  reply	other threads:[~2008-09-09 17:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-09 14:39 Cleanup mark-during-GC debug checks hanwenn
2008-09-09 17:34 ` Ludovic Courtès [this message]
2008-09-09 18:15   ` Andy Wingo
2008-09-10  1:13   ` Han-Wen Nienhuys
2008-09-10  7:36     ` Ludovic Courtès
2008-09-10 19:12     ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sks9i5ow.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).