unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH] Unicode string normalization
Date: Sun, 03 Jan 2010 00:01:38 +0100	[thread overview]
Message-ID: <87skaocdrh.fsf@gnu.org> (raw)
In-Reply-To: 2bc5f8211001012138r20128284k824f24e332c37a1e@mail.gmail.com

Hi Julian,

Julian Graham <joolean@gmail.com> writes:

> Find attached a patch that adds C and Scheme support for the four
> Unicode string normalization forms [0], along with documentation and
> unit tests.  The API matches the one described in R6RS Standard
> Libraries 1.2 [1].  Questions?  Comments?

Looks good to me, please push!

[

+    }
+  else w_str = (scm_t_uint32 *) scm_i_string_wide_chars (string);

Indentation slightly wrong here.

]

Thanks!

Ludo’.





  reply	other threads:[~2010-01-02 23:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-02  5:38 [PATCH] Unicode string normalization Julian Graham
2010-01-02 23:01 ` Ludovic Courtès [this message]
2010-01-03  6:15   ` Julian Graham
2010-01-03 12:43     ` Andy Wingo
2010-01-05  2:04 ` Mike Gran
2010-01-05 15:00   ` Julian Graham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87skaocdrh.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).