unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH] guile-snarf: allow multiple init actions on one line
Date: Thu, 24 Feb 2011 20:31:49 +0100	[thread overview]
Message-ID: <87sjvdw7oa.fsf@gnu.org> (raw)
In-Reply-To: 871v2zpsy5.fsf@olor.terpri.org

Hi Brian,

Thanks for the patches!

I haven’t look at the other patch yet, but about this one:

BT Templeton <bpt@hcoop.net> writes:

> +#!/bin/sh

Can you add a copyright/license header here?

> +snarf_test ()
> +{
> +    local x
> +    x=$(snarf "$1")
> +    if [ x"$x" != x"$2" ]; then

‘local’ and ‘$(...)’ are Bash extensions.  Can you remove ‘local’ and
use backquotes instead of $(...)?

> +snarf_test "^^a^:^" "a;"
> +snarf_test "  ^  ^  b  ^  :  ^  " "b;"
> +snarf_test "c\n^^d^:^\ne" "d;"
> +snarf_test "f^^g^:^h" "g;"
> +snarf_test "^^i^:^j^^k^:^" "i;k;"

Which of these should work with the current guile-snarf, and which
should work only with yours?

Thanks!

Ludo’.




  reply	other threads:[~2011-02-24 19:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22 19:14 [PATCH] guile-snarf: allow multiple init actions on one line BT Templeton
2011-02-22 19:26 ` Andy Wingo
2011-02-22 23:09   ` BT Templeton
2011-02-24 19:31     ` Ludovic Courtès [this message]
2011-02-24 20:42       ` Andreas Rottmann
2011-02-24 21:49         ` Ludovic Courtès
2011-02-25 11:01           ` Andy Wingo
2011-03-04 10:34 ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjvdw7oa.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).