From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH 1/6] split linker out of elf module Date: Wed, 22 May 2013 22:39:17 +0200 Message-ID: <87sj1e92bu.fsf@gnu.org> References: <1368889540-27139-1-git-send-email-wingo@pobox.com> <1368889540-27139-2-git-send-email-wingo@pobox.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1369255189 12219 80.91.229.3 (22 May 2013 20:39:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 May 2013 20:39:49 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed May 22 22:39:49 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UfFp2-0002nx-JO for guile-devel@m.gmane.org; Wed, 22 May 2013 22:39:44 +0200 Original-Received: from localhost ([::1]:35998 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfFp2-00007u-8i for guile-devel@m.gmane.org; Wed, 22 May 2013 16:39:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfFov-00006v-OH for guile-devel@gnu.org; Wed, 22 May 2013 16:39:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfFoq-0006rC-IV for guile-devel@gnu.org; Wed, 22 May 2013 16:39:37 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:56273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfFoq-0006qo-CI for guile-devel@gnu.org; Wed, 22 May 2013 16:39:32 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UfFop-0002hF-Kr for guile-devel@gnu.org; Wed, 22 May 2013 22:39:31 +0200 Original-Received: from reverse-83.fdn.fr ([80.67.176.83]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 22 May 2013 22:39:31 +0200 Original-Received: from ludo by reverse-83.fdn.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 22 May 2013 22:39:31 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 26 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: reverse-83.fdn.fr User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 3 Prairial an 221 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Cancel-Lock: sha1:pOZczAAd+HgSyuNAEyVDiSPqTKE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16409 Archived-At: Hello! Note: I’m just familiarizing with the new code, so I may miss things, and may make mostly superficial comments. Andy Wingo skribis: > * module/Makefile.am: > * module/system/vm/linker.scm: New file, split out of (system vm elf). > > * module/system/vm/elf.scm: Remove linking capabilities. > > * module/language/objcode/elf.scm: Adapt caller to use (system vm > linker). > > * test-suite/tests/linker.test: New test. Looks good. Would be nice to mention variable names too. It seems elf.scm would benefit from byte structures similar to those announced by Taylan on guile-user. That’s more for aesthetics though, and definitely not blocking. Docstrings are lacking in those files. Ludo’.