unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH] Implement R7RS 'syntax-error'
Date: Wed, 08 Jan 2014 12:48:39 +0100	[thread overview]
Message-ID: <87sisy7kyw.fsf@gnu.org> (raw)
In-Reply-To: 87y53gd6tg.fsf@netris.org

Mark H Weaver <mhw@netris.org> skribis:

> From 9f4f8641d0218525a2fc58ef6f8c6728145f0def Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Thu, 19 Dec 2013 13:22:50 -0500
> Subject: [PATCH] Implement R7RS 'syntax-error'.
>
> * module/ice-9/psyntax.scm (syntax-error): New macro.
>   (syntax-rules): Handle 'syntax-error' templates specially
>   for improved error reporting.
>
> * module/ice-9/psyntax-pp.scm: Regenerate.
>
> * doc/ref/api-macros.texi (Syntax Rules): Add docs.
>
> * test-suite/tests/syntax.test: Add tests.

Looks good to me.  The log should mention the new section in
api-macros.texi.

> +@subsubsection Reporting syntax errors in macros

Should be capitalized.

Thanks!

Ludo’.




      reply	other threads:[~2014-01-08 11:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 18:38 [PATCH] Implement R7RS 'syntax-error' Mark H Weaver
2014-01-08 11:48 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sisy7kyw.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).