unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
* Re: guile and visibility problems
       [not found]   ` <485FE03F.4020609@yahoo.com>
@ 2008-07-02 22:01     ` Ludovic Courtès
  2008-07-04 20:26       ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2008-07-02 22:01 UTC (permalink / raw)
  To: phorgan1; +Cc: guile-devel

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Hi Patrick,

Sorry for the delay...

Patrick Horgan <phorgan1@gmail.com> writes:

> gcc (GCC) 4.3.1
> Linux dell 2.6.24-19-generic #1 SMP Wed Jun 18 14:43:41 UTC 2008 i686
> GNU/Linux

OK.  I had been using 4.2.3 until now, and I was able to reproduce the
problem with 4.3.1 (with 4.3, symbols not declared as `extern' are
considered as "common" symbols).

Can you try out the attached patch?  It seems to fix the problem for me.
To apply it:

  $ cd /path/to/guile
  $ patch -p1 < ,,no-common-symbols.diff

Thanks in advance,
Ludovic.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: The patch --]
[-- Type: text/x-patch, Size: 495 bytes --]

diff --git a/libguile/__scm.h b/libguile/__scm.h
index 76b4448..30077fd 100644
--- a/libguile/__scm.h
+++ b/libguile/__scm.h
@@ -101,9 +101,9 @@
  * as having "internal" linkage.  */
 #if (defined __GNUC__) && \
   ((__GNUC__ >= 4) || (__GNUC__ == 3 && __GNUC_MINOR__ == 3))
-# define SCM_INTERNAL  __attribute__ ((__visibility__ ("internal")))
+# define SCM_INTERNAL  extern __attribute__ ((__visibility__ ("internal")))
 #else
-# define SCM_INTERNAL
+# define SCM_INTERNAL  extern
 #endif
 
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: guile and visibility problems
  2008-07-02 22:01     ` guile and visibility problems Ludovic Courtès
@ 2008-07-04 20:26       ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2008-07-04 20:26 UTC (permalink / raw)
  To: guile-devel; +Cc: phorgan1

Hi,

All this is now fixed in Git.

Thanks!

Ludovic.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-04 20:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <485ACACB.5040405@yahoo.com>
     [not found] ` <878wwwa5mn.fsf@gnu.org>
     [not found]   ` <485FE03F.4020609@yahoo.com>
2008-07-02 22:01     ` guile and visibility problems Ludovic Courtès
2008-07-04 20:26       ` Ludovic Courtès

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).