From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-6-75-g9c246c0 Date: Tue, 05 Jan 2010 18:57:07 +0100 Message-ID: <87r5q48mfg.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1262714865 7705 80.91.229.12 (5 Jan 2010 18:07:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Jan 2010 18:07:45 +0000 (UTC) Cc: guile-devel@gnu.org To: "Andy Wingo" Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Jan 05 19:07:37 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NSDod-0000pU-8t for guile-devel@m.gmane.org; Tue, 05 Jan 2010 19:07:35 +0100 Original-Received: from localhost ([127.0.0.1]:50495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSDei-0004pE-HY for guile-devel@m.gmane.org; Tue, 05 Jan 2010 12:57:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSDef-0004ne-8q for guile-devel@gnu.org; Tue, 05 Jan 2010 12:57:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSDea-0004hA-L6 for guile-devel@gnu.org; Tue, 05 Jan 2010 12:57:16 -0500 Original-Received: from [199.232.76.173] (port=54406 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSDea-0004gw-Ac for guile-devel@gnu.org; Tue, 05 Jan 2010 12:57:12 -0500 Original-Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:6030) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1NSDeZ-0001k2-IW for guile-devel@gnu.org; Tue, 05 Jan 2010 12:57:11 -0500 X-IronPort-AV: E=Sophos;i="4.47,507,1257116400"; d="scan'208";a="41068264" Original-Received: from laptop-147-210-128-170.labri.fr (HELO nixey) ([147.210.128.170]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 05 Jan 2010 18:57:07 +0100 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 =?iso-8859-1?Q?Niv=F4se?= an 218 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: (Andy Wingo's message of "Tue, 05 Jan 2010 15:29:58 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9828 Archived-At: Hi Andy! "Andy Wingo" writes: > commit 9fdf9fd3ea7130fd85eaf0a333a965ac4d2b07c3 > Author: Andy Wingo > Date: Tue Jan 5 16:15:14 2010 +0100 > > move subr implementation details to gsubr.[ch] >=20=20=20=20=20 > * libguile/procs.h: Move subr macros to gsubr.h. > * libguile/procs.c (scm_c_make_subr, scm_c_make_subr_with_generic) > (scm_c_define_subr, scm_c_define_subr_with_generic): Remove these, > because they deal in subr types, and now there is only one subr typ= e. This is slightly scary, because these were really-public functions, but I guess there=E2=80=99s no other choice anyway (and fundamentally I think t= his change is going in the Right Direction!). > +/* Deprecated 2010-01-05, use SCM_PRIMITIVE_P instead */ > +#define scm_subr_p(x) (SCM_PRIMITIVE_P (x)) Can you change it so it generates a link-time and run-time warning? See, e.g., =E2=80=98scm_mask_ints=E2=80=99. > +/* Return the most suitable subr type for a subr with REQ required argum= ents, > + OPT optional arguments, and REST (0 or 1) arguments. This has to be = in > + sync with `create_gsubr ()'. */ > +#define SCM_SUBR_ARITY_TO_TYPE(req, opt, rest) \ > + (scm_tc7_gsubr | (SCM_GSUBR_MAKTYPE (req, opt, rest) << 8U)) =E2=80=9CMost suitable=E2=80=9D and the second sentence can be removed now. Thanks, Ludo=E2=80=99.