Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-11-210-g648da03

Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-11-210-g648da03

[Thien-Thi Nguyen]

() ludo@gnu.org (Ludovic Courtès)
() Sat, 24 Jul 2010 18:34:50 +0200

   >  noinst_SCRIPTS = guile-doc-snarf guile-snarf-docs guile-func-name-check

   As seen at <http://hydra.nixos.org/build/495522>,
   ‘guile-func-name-check’ is now missing from the tarball.

Sorry about that!  I will remember to check "make dist" prior
to pushing in the future.

   Perhaps the variable above should be renamed to
   ‘dist_noinst_SCRIPTS’ or something like that?

Previously, automake included guile-func-name-check in the
list of files to be distributed due to it being named by
‘AC_CONFIG_FILES’ (via ‘GUILE_CONFIG_SCRIPT’).  Because the
others in that var (‘guile-doc-snarf’, ‘guile-snarf-docs’)
fall in the same category, converting the ‘noinst_SCRIPTS’ to
‘dist_noinst_SCRIPTS’ is overkill for them.  So i suggest:

  noinst_SCRIPTS = guile-doc-snarf guile-snarf-docs

and moving ‘guile-func-name-check’ to ‘EXTRA_DIST’.  I am in
the process of testing this and will push it If All Goes Well
unless there are any objections.

[cc redirected to guile-devel]

Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-11-210-g648da03

[Thien-Thi Nguyen]

() Thien-Thi Nguyen <ttn@gnuvola.org>
() Sat, 24 Jul 2010 22:11:24 +0200

   and moving ‘guile-func-name-check’ to ‘EXTRA_DIST’

Forgot to mention: Another reason to prefer ‘EXTRA_DIST’ is that foo_SCRIPTS
implies executable (chmod +x) programs, which ‘guile-func-name-check’ is not.
Placing it in ‘EXTRA_DIST’ avoids making this implication, expressing more
directly the intention.

Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-11-210-g648da03

[Ludovic Courtès]

Hi!

Thien-Thi Nguyen <ttn@gnuvola.org> writes:

> Previously, automake included guile-func-name-check in the
> list of files to be distributed due to it being named by
> ‘AC_CONFIG_FILES’ (via ‘GUILE_CONFIG_SCRIPT’).  Because the
> others in that var (‘guile-doc-snarf’, ‘guile-snarf-docs’)
> fall in the same category, converting the ‘noinst_SCRIPTS’ to
> ‘dist_noinst_SCRIPTS’ is overkill for them.  So i suggest:
>
>   noinst_SCRIPTS = guile-doc-snarf guile-snarf-docs
>
> and moving ‘guile-func-name-check’ to ‘EXTRA_DIST’.  I am in
> the process of testing this and will push it If All Goes Well
> unless there are any objections.

Fine with me!

Thanks,
Ludo’.