From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH 2/4] Add implementation of "transcoded ports" Date: Sat, 20 Nov 2010 23:52:45 +0100 Message-ID: <87r5efsj42.fsf@gnu.org> References: <87ipzsvp9y.fsf@gnu.org> <1290274833-24970-2-git-send-email-a.rottmann@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1290293588 12132 80.91.229.12 (20 Nov 2010 22:53:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 20 Nov 2010 22:53:08 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Nov 20 23:53:04 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PJwIp-0001FE-6T for guile-devel@m.gmane.org; Sat, 20 Nov 2010 23:53:03 +0100 Original-Received: from localhost ([127.0.0.1]:33601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJwIo-0001lm-Pw for guile-devel@m.gmane.org; Sat, 20 Nov 2010 17:53:02 -0500 Original-Received: from [140.186.70.92] (port=51602 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJwIm-0001le-8C for guile-devel@gnu.org; Sat, 20 Nov 2010 17:53:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJwIk-000892-OK for guile-devel@gnu.org; Sat, 20 Nov 2010 17:53:00 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:35112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJwIk-00088r-DM for guile-devel@gnu.org; Sat, 20 Nov 2010 17:52:58 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PJwIj-0001CC-5j for guile-devel@gnu.org; Sat, 20 Nov 2010 23:52:57 +0100 Original-Received: from yoda.fdn.fr ([80.67.169.18]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 20 Nov 2010 23:52:57 +0100 Original-Received: from ludo by yoda.fdn.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 20 Nov 2010 23:52:57 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 51 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: yoda.fdn.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 Brumaire an 219 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) Cancel-Lock: sha1:O0UNolT08jZ0gJYCcu3QKRICnqk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11179 Archived-At: Hi! Andreas Rottmann writes: > * libguile/r6rs-ports.c (make_tp, tp_write, tp_fill_input, tp_flush, > tp_close, initialize_transcoded_ports, scm_transcoded_port): New > functions. > (scm_init_r6rs_ports): Call `initialize_transcoded_ports'. > * module/rnrs/ports.scm (transcoded-port): Remove, this is now > implemented in C. > * test-suite/tests/r6rs-ports.test (8.2.6 Input and output ports): Added a > few tests for `transcoded-port'. Great! This looks good to me, modulo the minor things below: > + /* We can't use scm_c_read() here, since it blocks until the whole > + block has been read or EOF */ Please write it “`scm_c_read'” and add a period at the end. > +SCM_DEFINE (scm_transcoded_port, > + "transcoded-port", 2, 0, 0, > + (SCM port, SCM transcoder), > + "") Docstring please. :-) > + SCM_VALIDATE_STRUCT (SCM_ARG1, transcoder); This type check is too weak. > + /* SCM_CLR_PORT_OPEN_FLAG (port); */ Meaning of this comment? > +(with-test-prefix "8.2.6 Input and output ports" > + (pass-if "transcoded-port [output]" > + (let ((s "Hello\n\304\326\334")) It seems that it’s not actual UTF-8, or maybe the message mangled it somehow? > + (call-with-port (transcoded-port bv-port (make-transcoder (utf-8-codec))) I think you forgot the patch that adds ‘make-transcoder’ and ‘utf-8-codec’. :-) Can you send an updated patch (or pair of patches)? Thanks, Ludo’.