[PATCH] Undeprecate read syntax for uniform complex vectors

[PATCH] Undeprecate read syntax for uniform complex vectors

[Mark H Weaver]

[-- Attachment #1: Type: text/plain, Size: 40 bytes --]

FYI, I just pushed this fix.

    Mark


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Undeprecate read syntax for uniform complex vectors --]
[-- Type: text/x-diff, Size: 1136 bytes --]

From df941b5b62721d061ce5381a1a6400609e8a10b8 Mon Sep 17 00:00:00 2001
From: Mark H Weaver <mhw@netris.org>
Date: Tue, 5 Apr 2011 19:42:06 -0400
Subject: [PATCH] Undeprecate read syntax for uniform complex vectors

* libguile/read.c (scm_read_sharp): Move the "#c..." case outside of
  #if SCM_ENABLE_DEPRECATED, and to the same section which handles
  "#s...", "#u..." and "#f...".
  Thanks to Andreas Rottmann <a.rottmann@gmx.at> for the bug report.
---
 libguile/read.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libguile/read.c b/libguile/read.c
index 5be3bd9..a05a86d 100644
--- a/libguile/read.c
+++ b/libguile/read.c
@@ -1329,6 +1329,7 @@ scm_read_sharp (scm_t_wchar chr, SCM port)
     case 's':
     case 'u':
     case 'f':
+    case 'c':
       /* This one may return either a boolean or an SRFI-4 vector.  */
       return (scm_read_srfi4_vector (chr, port));
     case 'v':
@@ -1348,7 +1349,6 @@ scm_read_sharp (scm_t_wchar chr, SCM port)
 #if SCM_ENABLE_DEPRECATED
       /* See below for 'i' and 'e'. */
     case 'a':
-    case 'c':
     case 'y':
     case 'h':
     case 'l':
-- 
1.7.1

Re: [PATCH] Undeprecate read syntax for uniform complex vectors

[Andy Wingo]

On Wed 06 Apr 2011 01:51, Mark H Weaver <mhw@netris.org> writes:

> FYI, I just pushed this fix.
>
> * libguile/read.c (scm_read_sharp): Move the "#c..." case outside of
>   #if SCM_ENABLE_DEPRECATED, and to the same section which handles
>   "#s...", "#u..." and "#f...".
>   Thanks to Andreas Rottmann <a.rottmann@gmx.at> for the bug report.

Thanks!  What bug does it fix?  Sorry for being obtuse :)

Andy
-- 
http://wingolog.org/

Re: [PATCH] Undeprecate read syntax for uniform complex vectors

[Mark H Weaver]

Andy Wingo <wingo@pobox.com> writes:
> On Wed 06 Apr 2011 01:51, Mark H Weaver <mhw@netris.org> writes:
>
>> FYI, I just pushed this fix.
>>
>> * libguile/read.c (scm_read_sharp): Move the "#c..." case outside of
>>   #if SCM_ENABLE_DEPRECATED, and to the same section which handles
>>   "#s...", "#u..." and "#f...".
>>   Thanks to Andreas Rottmann <a.rottmann@gmx.at> for the bug report.
>
> Thanks!  What bug does it fix?  Sorry for being obtuse :)

Before this fix, srfi-4.test failed on line 439, when run on a guile
compiled with --disable-deprecated.  That line contains the literal
uniform complex vector #c32(+inf.0 -inf.0 +nan.0)

    Best,
     Mark

Re: [PATCH] Undeprecate read syntax for uniform complex vectors

[Andreas Rottmann]

Andy Wingo <wingo@pobox.com> writes:

> On Wed 06 Apr 2011 01:51, Mark H Weaver <mhw@netris.org> writes:
>
>> FYI, I just pushed this fix.
>>
>> * libguile/read.c (scm_read_sharp): Move the "#c..." case outside of
>>   #if SCM_ENABLE_DEPRECATED, and to the same section which handles
>>   "#s...", "#u..." and "#f...".
>>   Thanks to Andreas Rottmann <a.rottmann@gmx.at> for the bug report.
>
> Thanks!  What bug does it fix?  Sorry for being obtuse :)
>
A test suite failure in srfi-4.test when building with
--disable-deprecated, see also:

http://rotty.yi.org/irclogs/freenode/%23guile/2011-04-06/#e18

Regards, Rotty
-- 
Andreas Rottmann -- <http://rotty.yi.org/>

Re: [PATCH] Undeprecate read syntax for uniform complex vectors

[Andy Wingo]

On Wed 06 Apr 2011 22:20, Mark H Weaver <mhw@netris.org> writes:

> Andy Wingo <wingo@pobox.com> writes:
>> On Wed 06 Apr 2011 01:51, Mark H Weaver <mhw@netris.org> writes:
>>
>>> FYI, I just pushed this fix.
>>>
>>> * libguile/read.c (scm_read_sharp): Move the "#c..." case outside of
>>>   #if SCM_ENABLE_DEPRECATED, and to the same section which handles
>>>   "#s...", "#u..." and "#f...".
>>>   Thanks to Andreas Rottmann <a.rottmann@gmx.at> for the bug report.
>>
>> Thanks!  What bug does it fix?  Sorry for being obtuse :)
>
> Before this fix, srfi-4.test failed on line 439, when run on a guile
> compiled with --disable-deprecated.  That line contains the literal
> uniform complex vector #c32(+inf.0 -inf.0 +nan.0)

Ah, I see.  Thanks!

Andy
-- 
http://wingolog.org/