From: Andy Wingo <wingo@pobox.com>
To: Nala Ginrut <nalaginrut@gmail.com>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] add new read-delimited option to return #f while terminating delimiter can't be found.
Date: Tue, 22 Jan 2013 13:44:14 +0100 [thread overview]
Message-ID: <87r4ldv141.fsf@pobox.com> (raw)
In-Reply-To: <1358413679.2720.10.camel@Renee-desktop.suse> (Nala Ginrut's message of "Thu, 17 Jan 2013 17:07:59 +0800")
On Thu 17 Jan 2013 10:07, Nala Ginrut <nalaginrut@gmail.com> writes:
> On Wed, 2013-01-16 at 18:42 +0100, Andy Wingo wrote:
>> On Wed 07 Mar 2012 17:32, Nala Ginrut <nalaginrut@gmail.com> writes:
>>
>> > (call-with-input-string "asdf" (lambda (port) (read-delimited "@" port
>> > 'fail))))
>>
>> LGTM; just missing a test case. I would tighten up the documentation,
>> too: make sure each sentence is actually a sentence. (It's a common
>> mistake, even for native speakers.)
>>
>
> Attached the patch for rdelim test case. Please review it.
Looks fine to me. Please submit one patch with the change, the test
case, and the doc all in one. Thanks :)
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2013-01-22 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 16:32 [PATCH] add new read-delimited option to return #f while terminating delimiter can't be found Nala Ginrut
2013-01-16 17:42 ` Andy Wingo
2013-01-17 9:07 ` Nala Ginrut
2013-01-22 12:44 ` Andy Wingo [this message]
2013-01-22 16:41 ` Nala Ginrut
2013-01-23 10:00 ` Andy Wingo
2013-01-23 10:24 ` Nala Ginrut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4ldv141.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=nalaginrut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).