From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: array-copy! is slow & array-map.c Date: Wed, 03 Apr 2013 14:50:24 +0200 Message-ID: <87r4irok1b.fsf@gnu.org> References: <919253B8-A19B-418F-9F2E-603A2AE9DC7E@bluewin.ch> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1364993442 25781 80.91.229.3 (3 Apr 2013 12:50:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Apr 2013 12:50:42 +0000 (UTC) Cc: guile-devel@gnu.org To: Daniel Llorens Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Apr 03 14:51:09 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UNN9h-0004I7-Ha for guile-devel@m.gmane.org; Wed, 03 Apr 2013 14:51:09 +0200 Original-Received: from localhost ([::1]:37649 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNN9I-00048h-QJ for guile-devel@m.gmane.org; Wed, 03 Apr 2013 08:50:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNN9B-00047k-7b for guile-devel@gnu.org; Wed, 03 Apr 2013 08:50:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNN99-0005GP-SY for guile-devel@gnu.org; Wed, 03 Apr 2013 08:50:37 -0400 Original-Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=50305 helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNN99-0005En-Ld for guile-devel@gnu.org; Wed, 03 Apr 2013 08:50:35 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id B4207C15A; Wed, 3 Apr 2013 14:50:25 +0200 (CEST) Original-Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rMuPvKkAqmHL; Wed, 3 Apr 2013 14:50:25 +0200 (CEST) Original-Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id 36A0A58D; Wed, 3 Apr 2013 14:50:25 +0200 (CEST) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 Germinal an 221 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: (Daniel Llorens's message of "Tue, 2 Apr 2013 16:06:16 +0200") User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2a01:e0b:1:123:ca0a:a9ff:fe03:271e X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16119 Archived-At: Daniel Llorens skribis: > These two patches do it for array-map!. > > The first patch avoids cons for the 1-argument case. The second patch rem= oves the double indirection for the first two arguments in every case. Sinc= e there's some work done inside the loop, the improvement is smaller than f= or array-copy! or array-fill!. Could you provide a patch that adds test cases for array-map! in arrays.test? I=E2=80=99d like to have a minimal safety net before applying these. TIA, :-) Ludo=E2=80=99.