* Avoid warning about alloca in read.c
@ 2016-07-16 17:18 Eli Zaretskii
2016-07-22 7:17 ` Eli Zaretskii
2016-07-23 20:57 ` Andy Wingo
0 siblings, 2 replies; 6+ messages in thread
From: Eli Zaretskii @ 2016-07-16 17:18 UTC (permalink / raw)
To: guile-devel
CC libguile_2.0_la-read.lo
read.c: In function 'try_read_ci_chars':
read.c:983:3: warning: implicit declaration of function 'alloca' [-Wimplicit-function-declaration]
read.c:983:22: warning: incompatible implicit declaration of built-in function 'alloca' [enabled by default]
The patch to avoid this warning is below. OK to commit?
--- libguile/read.c~0 2016-01-02 16:24:55.000000000 +0200
+++ libguile/read.c 2016-07-15 12:38:42.195125000 +0300
@@ -33,6 +33,10 @@
#include <c-strcase.h>
#include <c-ctype.h>
+#ifdef __MINGW32__
+#include <alloca.h>
+#endif
+
#include "libguile/_scm.h"
#include "libguile/bytevectors.h"
#include "libguile/chars.h"
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Avoid warning about alloca in read.c
2016-07-16 17:18 Avoid warning about alloca in read.c Eli Zaretskii
@ 2016-07-22 7:17 ` Eli Zaretskii
2016-07-23 20:57 ` Andy Wingo
1 sibling, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2016-07-22 7:17 UTC (permalink / raw)
To: guile-devel
Ping!
> Date: Sat, 16 Jul 2016 20:18:26 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> CC libguile_2.0_la-read.lo
> read.c: In function 'try_read_ci_chars':
> read.c:983:3: warning: implicit declaration of function 'alloca' [-Wimplicit-function-declaration]
> read.c:983:22: warning: incompatible implicit declaration of built-in function 'alloca' [enabled by default]
>
> The patch to avoid this warning is below. OK to commit?
>
> --- libguile/read.c~0 2016-01-02 16:24:55.000000000 +0200
> +++ libguile/read.c 2016-07-15 12:38:42.195125000 +0300
> @@ -33,6 +33,10 @@
> #include <c-strcase.h>
> #include <c-ctype.h>
>
> +#ifdef __MINGW32__
> +#include <alloca.h>
> +#endif
> +
> #include "libguile/_scm.h"
> #include "libguile/bytevectors.h"
> #include "libguile/chars.h"
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Avoid warning about alloca in read.c
2016-07-16 17:18 Avoid warning about alloca in read.c Eli Zaretskii
2016-07-22 7:17 ` Eli Zaretskii
@ 2016-07-23 20:57 ` Andy Wingo
2016-07-24 2:39 ` Eli Zaretskii
1 sibling, 1 reply; 6+ messages in thread
From: Andy Wingo @ 2016-07-23 20:57 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: guile-devel
On Sat 16 Jul 2016 19:18, Eli Zaretskii <eliz@gnu.org> writes:
> CC libguile_2.0_la-read.lo
> read.c: In function 'try_read_ci_chars':
> read.c:983:3: warning: implicit declaration of function 'alloca' [-Wimplicit-function-declaration]
> read.c:983:22: warning: incompatible implicit declaration of built-in function 'alloca' [enabled by default]
>
> The patch to avoid this warning is below. OK to commit?
>
> --- libguile/read.c~0 2016-01-02 16:24:55.000000000 +0200
> +++ libguile/read.c 2016-07-15 12:38:42.195125000 +0300
> @@ -33,6 +33,10 @@
> #include <c-strcase.h>
> #include <c-ctype.h>
>
> +#ifdef __MINGW32__
> +#include <alloca.h>
> +#endif
> +
OK to commit but please remove the ifdef -- just include <alloca.h> in all
cases.
Thanks!
Andy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Avoid warning about alloca in read.c
2016-07-23 20:57 ` Andy Wingo
@ 2016-07-24 2:39 ` Eli Zaretskii
2016-07-24 13:35 ` Andy Wingo
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2016-07-24 2:39 UTC (permalink / raw)
To: Andy Wingo; +Cc: guile-devel
> From: Andy Wingo <wingo@pobox.com>
> Cc: guile-devel@gnu.org
> Date: Sat, 23 Jul 2016 22:57:02 +0200
>
> > +#ifdef __MINGW32__
> > +#include <alloca.h>
> > +#endif
> > +
>
> OK to commit but please remove the ifdef -- just include <alloca.h> in all
> cases.
Is that header available on all supported platforms?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Avoid warning about alloca in read.c
2016-07-24 2:39 ` Eli Zaretskii
@ 2016-07-24 13:35 ` Andy Wingo
2016-07-24 15:15 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Andy Wingo @ 2016-07-24 13:35 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: guile-devel
On Sun 24 Jul 2016 04:39, Eli Zaretskii <eliz@gnu.org> writes:
>> From: Andy Wingo <wingo@pobox.com>
>> Cc: guile-devel@gnu.org
>> Date: Sat, 23 Jul 2016 22:57:02 +0200
>>
>> > +#ifdef __MINGW32__
>> > +#include <alloca.h>
>> > +#endif
>> > +
>>
>> OK to commit but please remove the ifdef -- just include <alloca.h> in all
>> cases.
>
> Is that header available on all supported platforms?
Yes, we use a Gnulib module to ensure that some workable version is
present.
Andy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Avoid warning about alloca in read.c
2016-07-24 13:35 ` Andy Wingo
@ 2016-07-24 15:15 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2016-07-24 15:15 UTC (permalink / raw)
To: Andy Wingo; +Cc: guile-devel
> From: Andy Wingo <wingo@pobox.com>
> Cc: guile-devel@gnu.org
> Date: Sun, 24 Jul 2016 15:35:08 +0200
>
> >> > +#ifdef __MINGW32__
> >> > +#include <alloca.h>
> >> > +#endif
> >> > +
> >>
> >> OK to commit but please remove the ifdef -- just include <alloca.h> in all
> >> cases.
> >
> > Is that header available on all supported platforms?
>
> Yes, we use a Gnulib module to ensure that some workable version is
> present.
Thanks, pushed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-24 15:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-16 17:18 Avoid warning about alloca in read.c Eli Zaretskii
2016-07-22 7:17 ` Eli Zaretskii
2016-07-23 20:57 ` Andy Wingo
2016-07-24 2:39 ` Eli Zaretskii
2016-07-24 13:35 ` Andy Wingo
2016-07-24 15:15 ` Eli Zaretskii
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).