unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: Avoid warning about alloca in read.c
Date: Sun, 24 Jul 2016 15:35:08 +0200	[thread overview]
Message-ID: <87r3ajqhv7.fsf@pobox.com> (raw)
In-Reply-To: <831t2jvjxi.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 24 Jul 2016 05:39:21 +0300")

On Sun 24 Jul 2016 04:39, Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andy Wingo <wingo@pobox.com>
>> Cc: guile-devel@gnu.org
>> Date: Sat, 23 Jul 2016 22:57:02 +0200
>> 
>> > +#ifdef __MINGW32__
>> > +#include <alloca.h>
>> > +#endif
>> > +
>> 
>> OK to commit but please remove the ifdef -- just include <alloca.h> in all
>> cases.
>
> Is that header available on all supported platforms?

Yes, we use a Gnulib module to ensure that some workable version is
present.

Andy



  reply	other threads:[~2016-07-24 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-16 17:18 Avoid warning about alloca in read.c Eli Zaretskii
2016-07-22  7:17 ` Eli Zaretskii
2016-07-23 20:57 ` Andy Wingo
2016-07-24  2:39   ` Eli Zaretskii
2016-07-24 13:35     ` Andy Wingo [this message]
2016-07-24 15:15       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3ajqhv7.fsf@pobox.com \
    --to=wingo@pobox.com \
    --cc=eliz@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).