unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Alex Kost <alezost@gmail.com>
To: guile-devel@gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: Re: REPL Server: Guard against HTTP inter-protocol exploitation attacks.
Date: Wed, 12 Oct 2016 11:21:21 +0300	[thread overview]
Message-ID: <87r37mvuym.fsf_-_@gmail.com> (raw)
In-Reply-To: <20161011133746.47A04220168@vcs.savannah.gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22's\?\= message of "Tue, 11 Oct 2016 13:37:46 +0000 (UTC)")

Hello, I've noticed an insignificant typo in commit
08c021916dbd3a235a9f9cc33df4c418c0724e03 (in the fancy warning message).

[...]
> +               ;; Print a report to STDERR (POSIX file descriptor 2).
> +               ;; XXX Can we do better here?
> +               (call-with-port (dup->port 2 "w")
> +                 (cut format <> "
> +@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
> +@@ POSSIBLE BREAK-IN ATTEMPT ON THE REPL SERVER                @@
> +@@ BY AN HTTP INTER-PROTOCOL EXPLOITATION ATTACK.  See:        @@
> +@@ <https://en.wikipedia.org/wiki/Inter-protocol_exploitation> @@
> +@@ Possible HTTP request received: ~S
                                                                  ^^
Missing trailing "@@" in the above line.

> +@@ The associated socket has been closed.                      @@
> +@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@\n"
> +                      (string-append request-line
> +                                     drained-input)))))

-- 
Alex



       reply	other threads:[~2016-10-12  8:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161011133745.2333.41505@vcs.savannah.gnu.org>
     [not found] ` <20161011133746.47A04220168@vcs.savannah.gnu.org>
2016-10-12  8:21   ` Alex Kost [this message]
2016-10-12 12:23     ` REPL Server: Guard against HTTP inter-protocol exploitation attacks Ludovic Courtès
2016-10-13  8:46       ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r37mvuym.fsf_-_@gmail.com \
    --to=alezost@gmail.com \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).